Fix for issue #415 - WHEN_WITHOUT_ELSE doesn't recognize when expression in when branch #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
============================================
- Coverage 81.82% 81.78% -0.05%
- Complexity 1551 1555 +4
============================================
Files 73 73
Lines 3896 3897 +1
Branches 1244 1244
============================================
- Hits 3188 3187 -1
Misses 211 211
- Partials 497 499 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
changed the title
orchestr7
reviewed
Oct 26, 2020
| | 1 -> when (x) { | ||
| | 2 -> foo() | ||
| | } | ||
| | } |
There was a problem hiding this comment.
2 else should be here? why no warnings?
There was a problem hiding this comment.
Because in this cases return value of when expression is used afterwards, and the compiler can check whether the choice is exhaustive. Since we don't have information about expression type, we don't check these cases at all.
orchestr7
reviewed
Oct 26, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/WhenMustHaveElseRule.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #415