Rule 6.1.5: Explicit supertype qualification should not be used if there is not clash between called methods #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Implemented rule 6.1.5
### What's done: Added empty line
### What's done: Added empty line
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
============================================
- Coverage 81.90% 81.81% -0.09%
- Complexity 1576 1596 +20
============================================
Files 75 76 +1
Lines 3974 4026 +52
Branches 1259 1277 +18
============================================
+ Hits 3255 3294 +39
- Misses 212 214 +2
- Partials 507 518 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: added suppress
petertrr
changed the title
petertrr
reviewed
Oct 29, 2020
### What's done: Changed rule's logic.
### What's done: Changed rule's logic.
…pertype-qualification # Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml # info/available-rules.md
petertrr
requested changes
Oct 30, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
### What's done:
Fixed after review
### What's done:
Fixed after review
### What's done:
Fixed after review
petertrr
requested changes
Nov 9, 2020
| @@ -62,6 +62,8 @@ class DiktatRuleSetProvider(private val diktatConfigFile: String = "diktat-analy | |||
| ::PackageNaming, | |||
| ::IdentifierNaming, | |||
| // code structure | |||
| ::UselessSupertype, | |||
| ::LocalVariablesRule, | |||
There was a problem hiding this comment.
So, github shows it's still there
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/UselessSupertype.kt
Outdated
Show resolved
Hide resolved
…pertype-qualification
### What's done: Fixed after review
…pertype-qualification # Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml
petertrr
requested changes
Nov 13, 2020
| @@ -62,6 +62,8 @@ class DiktatRuleSetProvider(private val diktatConfigFile: String = "diktat-analy | |||
| ::PackageNaming, | |||
| ::IdentifierNaming, | |||
| // code structure | |||
| ::UselessSupertype, | |||
| ::LocalVariablesRule, | |||
There was a problem hiding this comment.
Please move LocalVariablesRule back if it's unintended move, the rest seems fine.
### What's done: Fixed after review
petertrr
approved these changes
Nov 13, 2020
…pertype-qualification # Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Implemented rule 6.1.5
Actions checklist