Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockStructureBraces assertion failed #461

Merged
merged 5 commits into from
Oct 30, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Oct 27, 2020

What's done:

Fixed bug with add children
closes #436

### What's done:
    Fixed bug with add children
@kentr0w kentr0w added the bug Something isn't working label Oct 27, 2020
### What's done:
    Fixed file to fix test
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #461 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #461      +/-   ##
============================================
+ Coverage     81.91%   81.97%   +0.05%     
- Complexity     1461     1464       +3     
============================================
  Files            71       71              
  Lines          3689     3689              
  Branches       1178     1178              
============================================
+ Hits           3022     3024       +2     
+ Misses          202      201       -1     
+ Partials        465      464       -1     
Flag Coverage Δ Complexity Δ
#unittests 81.97% <100.00%> (+0.05%) 1464.00 <0.00> (+3.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../cqfn/diktat/ruleset/rules/BlockStructureBraces.kt 83.80% <100.00%> (ø) 53.00 <0.00> (ø)
...n/org/cqfn/diktat/ruleset/utils/StringCaseUtils.kt 82.08% <0.00%> (ø) 0.00% <0.00%> (ø%)
...set/rules/calculations/AccurateCalculationsRule.kt 79.72% <0.00%> (+1.35%) 47.00% <0.00%> (+2.00%)
...fn/diktat/ruleset/rules/classes/DataClassesRule.kt 84.21% <0.00%> (+2.63%) 25.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9a4fc...f6d503e. Read the comment docs.

### What's done:
    Added to smoke test
### What's done:
   Remove useless test and add smoke test
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kentr0w kentr0w merged commit f3da291 into master Oct 30, 2020
@kentr0w kentr0w deleted the bugfix/BlockStructureBraces-assertion-failed branch October 30, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failed: anchorBefore == null || anchorBefore.getTreeParent() == parent
2 participants