Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding guide, chapter 1 after Native review #466

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

orchestr7
Copy link
Member

What's done:

Native speaker checked spelling and text

### What's done:
Native speaker checked spelling and text
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #466 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #466      +/-   ##
============================================
- Coverage     81.95%   81.87%   -0.08%     
- Complexity     1435     1478      +43     
============================================
  Files            69       71       +2     
  Lines          3591     3730     +139     
  Branches       1147     1195      +48     
============================================
+ Hits           2943     3054     +111     
- Misses          201      203       +2     
- Partials        447      473      +26     
Flag Coverage Δ Complexity Δ
#unittests 81.87% <ø> (-0.08%) 1478.00 <ø> (+43.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/diktat/ruleset/rules/StringTemplateFormatRule.kt 85.29% <0.00%> (-7.57%) 12.00% <0.00%> (+3.00%) ⬇️
...rg/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt 83.78% <0.00%> (-3.03%) 104.00% <0.00%> (+14.00%) ⬇️
...n/kotlin/org/cqfn/diktat/common/cli/CliArgument.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...n/org/cqfn/diktat/ruleset/utils/StringCaseUtils.kt 82.08% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../cqfn/diktat/ruleset/rules/BlockStructureBraces.kt 83.80% <0.00%> (ø) 53.00% <0.00%> (ø%)
...fn/diktat/common/config/rules/RulesConfigReader.kt 35.71% <0.00%> (ø) 4.00% <0.00%> (ø%)
...ktat/common/config/reader/ApplicationProperties.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...t/common/config/reader/JsonResourceConfigReader.kt 45.45% <0.00%> (ø) 3.00% <0.00%> (ø%)
...in/org/cqfn/diktat/ruleset/rules/WhiteSpaceRule.kt
...qfn/diktat/ruleset/rules/classes/SingleInitRule.kt 77.77% <0.00%> (ø) 10.00% <0.00%> (?%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e271109...c7c150b. Read the comment docs.

### What's done:
Moved chapter 0 to a separate file
@orchestr7 orchestr7 merged commit fdfbc74 into master Nov 2, 2020
@petertrr petertrr added the documentation Improvements or additions to documentation label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants