Making diktat consistent with own code style (rules.kdoc + diktat-rules tests) #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Applied code style in kdoc rules
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
============================================
+ Coverage 81.74% 81.83% +0.08%
- Complexity 1499 1501 +2
============================================
Files 71 71
Lines 3731 3765 +34
Branches 1203 1209 +6
============================================
+ Hits 3050 3081 +31
- Misses 209 210 +1
- Partials 472 474 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * detekt code check
…c-rules' into feature/diktat-code-style-in-kdoc-rules
### What's done: * Updated tests in diktat-rules
petertrr
changed the title
…c-rules' into feature/diktat-code-style-in-kdoc-rules
orchestr7
reviewed
Nov 3, 2020
| @@ -6,6 +6,8 @@ import org.cqfn.diktat.common.config.rules.isRuleEnabled | |||
| import org.cqfn.diktat.ruleset.utils.hasSuppress | |||
| import org.jetbrains.kotlin.com.intellij.lang.ASTNode | |||
|
|
|||
| typealias EmitType = ((offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit) | |||
orchestr7
approved these changes
Nov 3, 2020
| it.assertThat(actual.ruleId).`as`("Rule id").isEqualTo(expected.ruleId) | ||
| it.assertThat(actual.detail).`as`("Detailed message").isEqualTo(expected.detail) | ||
| it.assertThat(actual.canBeAutoCorrected).`as`("Can be autocorrected").isEqualTo(expected.canBeAutoCorrected) | ||
| it.assertThat(actual.line) |
There was a problem hiding this comment.
looks a little bit strange for short statements, but looks good for long. Where is the balance?
There was a problem hiding this comment.
It actually even isn't compliant with our current code style: we are forcing a line break after it, but I thought it looks too ugly. I'll add an issue about making this rule prettier and maybe taking into account text length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: