Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing warning message in KDOC_NO_CONSTRUCTOR_PROPERTY #497

Merged
merged 5 commits into from
Nov 9, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Nov 6, 2020

What's done:

Created new warning
closes #475

@kentr0w kentr0w added the bug Something isn't working label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #497 (ec8ef85) into master (ebee400) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #497   +/-   ##
=========================================
  Coverage     81.76%   81.77%           
  Complexity     1528     1528           
=========================================
  Files            72       72           
  Lines          3861     3862    +1     
  Branches       1234     1234           
=========================================
+ Hits           3157     3158    +1     
  Misses          210      210           
  Partials        494      494           
Flag Coverage Δ Complexity Δ
unittests 81.77% <100.00%> (+<0.01%) 0.00 <1.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 98.23% <100.00%> (+0.01%) 10.00 <0.00> (ø)
...org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt 81.81% <100.00%> (ø) 53.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebee400...e5d27a0. Read the comment docs.

### What's done:
  Made a little prettier
…ng-warn-message

# Conflicts:
#	diktat-analysis.yml
#	diktat-rules/src/main/resources/diktat-analysis-huawei.yml
#	diktat-rules/src/main/resources/diktat-analysis.yml
@kentr0w kentr0w merged commit 6d591d7 into master Nov 9, 2020
@kentr0w kentr0w deleted the bugfix/KDoc-confusing-warn-message branch November 9, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing warning message in KDOC_NO_CONSTRUCTOR_PROPERTY
2 participants