diktat-gradle-plugin #514
Merged
diktat-gradle-plugin #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added gradle plugin sources * Added gradle plugin to maven build
### What's done: * Added readme for gradle plugin * Disable gradle invocation on windows
### What's done: * Update build.gradle.kts
…' into feature/diktat-gradle-plugin#259
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=========================================
Coverage 81.79% 81.79%
Complexity 1596 1596
=========================================
Files 76 76
Lines 4026 4026
Branches 1278 1278
=========================================
Hits 3293 3293
Misses 215 215
Partials 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
### What's done: * Added instructions to README.md * Moved tasks to separate class * Fixed detekt check
…le-plugin#259 # Conflicts: # README.md
### What's done: * Generate sources in gradle * Updated README.md
### What's done: * Fix detekt run on gradle plugin marker
### What's done: * Support for gradle <6.4 * Refactoring
…' into feature/diktat-gradle-plugin#259
### What's done: * Detekt code style
### What's done: * Diktat code style
### What's done: * Disable version check to use JavaExec on gradle 6.8+ for now
orchestr7
reviewed
Nov 13, 2020
orchestr7
reviewed
Nov 13, 2020
orchestr7
reviewed
Nov 13, 2020
orchestr7
reviewed
Nov 13, 2020
orchestr7
reviewed
Nov 13, 2020
orchestr7
reviewed
Nov 13, 2020
orchestr7
reviewed
Nov 13, 2020
orchestr7
reviewed
Nov 13, 2020
orchestr7
reviewed
Nov 13, 2020
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt
Show resolved
Hide resolved
orchestr7
reviewed
Nov 13, 2020
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt
Show resolved
Hide resolved
orchestr7
reviewed
Nov 13, 2020
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Nov 13, 2020
| // configuration to provide JavaExec with correct classpath | ||
| val diktatConfiguration = project.configurations.create(DIKTAT_CONFIGURATION) { configuration -> | ||
| configuration.isVisible = false | ||
| configuration.dependencies.add(project.dependencies.create("org.jetbrains.kotlin:kotlin-stdlib:1.4.10")) |
There was a problem hiding this comment.
is there any way not to hardcode dependencies?
There was a problem hiding this comment.
I've added passing versions via properties from maven and a little of codegen to use them in plugin: 300fa1d
orchestr7
reviewed
Nov 13, 2020
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/Utils.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Nov 13, 2020
### What's done: * Fixes after review
### What's done: * Supply versions via project property
### What's done: * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #259
This should work on gradle 6.4+, because in this version they have introducesAdded version check and usage ofmainClassproperty forJavaExecinstead of soon to be deprecatedmain.mainfor older gradle versions, tested it on gradle 5.0.Fixme
JavaExec.