Support kotlin multiplatform project layout in PackageNaming rule #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added logic * Added tests
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
============================================
+ Coverage 81.76% 81.82% +0.06%
- Complexity 1550 1551 +1
============================================
Files 73 73
Lines 3894 3896 +2
Branches 1245 1244 -1
============================================
+ Hits 3184 3188 +4
- Misses 210 211 +1
+ Partials 500 497 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Nov 12, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Nov 12, 2020
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter1/PackageNamingWarnTest.kt
Show resolved
Hide resolved
### What's done: * Added list of allowed targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #397