Do not require configuration for every rule in yml file #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Provided default value * Edited all config files
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
============================================
- Coverage 81.81% 81.79% -0.03%
Complexity 1596 1596
============================================
Files 76 76
Lines 4026 4026
Branches 1277 1278 +1
============================================
- Hits 3294 3293 -1
- Misses 214 215 +1
Partials 518 518
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Nov 16, 2020
| - name: EXCEPTION_SUFFIX | ||
| enabled: true | ||
| configuration: {} | ||
| configuration: { } |
There was a problem hiding this comment.
This is a yml file for tests, so I've kept different versions for configuration, which should be valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #468
The issue stated that disabled rules don't need configuration, but all configuration options have default values and it will work.