New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule 6.1.3 Do not use the primary constructor if it is empty and has no sense #528

Merged

kentr0w merged 7 commits into master from feature/rule-6.1.3

Nov 23, 2020

Collaborator

kentr0w commented Nov 16, 2020

Actions checklist

Implemented Rule, added Warnings
Added tests on checks
Added tests on fixers
Updated diktat-analysis.yml
Updated available-rules.md
closes Rule 6.1.3: Do not use the primary constructor if it is empty and has no sense #439

Fixme

yes


          Rule 6.1.3

91ce46d

### What's done:
   Made rule

kentr0w requested review from petertrr, aktsay6 and orchestr7

November 16, 2020 11:08

codecov bot commented Nov 16, 2020 •

edited

Loading

Codecov Report

Merging #528 (a5ac7ab) into master (052bd9d) will increase coverage by 0.03%.
The diff coverage is 90.62%.

@@             Coverage Diff              @@
##             master     #528      +/-   ##
============================================
+ Coverage     81.68%   81.71%   +0.03%     
- Complexity     1641     1673      +32     
============================================
  Files            79       84       +5     
  Lines          4139     4223      +84     
  Branches       1307     1316       +9     
============================================
+ Hits           3381     3451      +70     
- Misses          229      238       +9     
- Partials        529      534       +5

Flag	Coverage Δ	Complexity Δ
unittests	`81.71% <90.62%> (+0.03%)`	`0.00 <15.00> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...lin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt	`93.75% <33.33%> (-1.19%)`	`32.00 <0.00> (ø)`
...ktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt	`90.00% <90.00%> (ø)`	`8.00 <8.00> (?)`
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt	`98.33% <100.00%> (+0.01%)`	`10.00 <0.00> (ø)`
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt	`97.29% <100.00%> (+0.03%)`	`8.00 <0.00> (ø)`
...qfn/diktat/ruleset/rules/classes/SingleInitRule.kt	`78.46% <100.00%> (+0.68%)`	`16.00 <0.00> (+6.00)`
.../cqfn/diktat/ruleset/rules/files/BlankLinesRule.kt	`100.00% <100.00%> (ø)`	`13.00 <7.00> (+1.00)`
...rg/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt	`83.95% <100.00%> (+0.17%)`	`110.00 <0.00> (+6.00)`
...g/cqfn/diktat/ruleset/rules/kdoc/KdocFormatting.kt	`77.12% <100.00%> (-0.15%)`	`73.00 <0.00> (ø)`
...tlin/org/cqfn/diktat/ruleset/utils/ASTConstants.kt	`100.00% <100.00%> (ø)`	`0.00 <0.00> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd9f90...a5ac7ab. Read the comment docs.

petertrr requested changes

View reviewed changes

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt Outdated Show resolved Hide resolved

...at-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter6/EmptyPrimaryConstructorWarnTest.kt Outdated Show resolved Hide resolved

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt Outdated Show resolved Hide resolved


          Rul 6.1.3

### What's done:
    Fixed after review

petertrr requested changes

View reviewed changes

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt Outdated Show resolved Hide resolved

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt Outdated Show resolved Hide resolved


          Rule 6.1.3

d3d79e7

### What's done:
   Fixed after review

petertrr requested changes

View reviewed changes

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt Outdated Show resolved Hide resolved

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt Outdated Show resolved Hide resolved

kentr0w added 2 commits

November 23, 2020 11:33


          rule 6.1.3

6837ec4

### What's done:
   Renamed arg


          Merge remote-tracking branch 'origin/master' into feature/rule-6.1.3

9dbad60

# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
#	diktat-rules/src/main/resources/diktat-analysis-huawei.yml
#	diktat-rules/src/main/resources/diktat-analysis.yml

petertrr changed the title ~~Rule 6.1.3~~ Rule 6.1.3 Do not use the primary constructor if it is empty and has no sense

petertrr requested changes

View reviewed changes

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt Outdated Show resolved Hide resolved


          rule 6.1.3

22a80d3

### What's done:
   Fixed bug

petertrr approved these changes

View reviewed changes


          Merge branch 'master' into feature/rule-6.1.3

a5ac7ab

kentr0w merged commit d8651d2 into master

kentr0w deleted the feature/rule-6.1.3 branch

November 23, 2020 16:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet