Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change generic-type algorithm #536

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Nov 17, 2020

What's done:

Changed algorithm

closes #493

### What's done:
    Changed algorithm
@kentr0w kentr0w added the bug Something isn't working label Nov 17, 2020
@kentr0w kentr0w added this to the Chapter 3 milestone Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #536 (30eea6b) into master (516347a) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #536      +/-   ##
============================================
+ Coverage     81.88%   81.90%   +0.02%     
- Complexity     1635     1636       +1     
============================================
  Files            78       78              
  Lines          4123     4123              
  Branches       1302     1302              
============================================
+ Hits           3376     3377       +1     
  Misses          219      219              
+ Partials        528      527       -1     
Flag Coverage Δ Complexity Δ
unittests 81.90% <50.00%> (+0.02%) 0.00 <5.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt 83.20% <50.00%> (+0.76%) 77.00 <5.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516347a...f20e64a. Read the comment docs.

### What's done:
    Fixed after review
### What's done:
    Added more tests
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 4d19224 into master Nov 17, 2020
@petertrr petertrr deleted the bugfix/generic-type-algorithm branch November 17, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic upper bound specification warns about [GENERIC_NAME] lint.
2 participants