Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function is not being simplified to expression body when semicolon is present #557

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Nov 19, 2020

What's done:

Fixed bug
closes #477

### What's done:
   Fixed bug
@kentr0w kentr0w added the bug Something isn't working label Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #557 (0e446fe) into master (052bd9d) will increase coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #557   +/-   ##
=========================================
  Coverage     81.68%   81.69%           
- Complexity     1641     1665   +24     
=========================================
  Files            79       83    +4     
  Lines          4139     4211   +72     
  Branches       1307     1315    +8     
=========================================
+ Hits           3381     3440   +59     
- Misses          229      238    +9     
- Partials        529      533    +4     
Flag Coverage Δ Complexity Δ
unittests 81.69% <90.00%> (+<0.01%) 0.00 <7.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...lin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt 93.75% <33.33%> (-1.19%) 32.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.26% <100.00%> (ø) 8.00 <0.00> (ø)
...qfn/diktat/ruleset/rules/classes/SingleInitRule.kt 78.46% <100.00%> (+0.68%) 16.00 <0.00> (+6.00)
.../cqfn/diktat/ruleset/rules/files/BlankLinesRule.kt 100.00% <100.00%> (ø) 13.00 <7.00> (+1.00)
...rg/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt 83.95% <100.00%> (+0.17%) 110.00 <0.00> (+6.00)
...g/cqfn/diktat/ruleset/rules/kdoc/KdocFormatting.kt 77.12% <100.00%> (-0.15%) 73.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/ASTConstants.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 79.31% <0.00%> (ø) 5.00% <0.00%> (?%)
...n/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt 100.00% <0.00%> (ø) 4.00% <0.00%> (?%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ccdbd...0e446fe. Read the comment docs.

@kentr0w kentr0w merged commit 0dd9f90 into master Nov 23, 2020
@kentr0w kentr0w deleted the bugfix/different-functions-due-semicolon branch November 23, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function is not being simplified to expression body when semicolon is present
2 participants