Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warnings to rules mapping in enum #558

Merged
merged 5 commits into from
Nov 23, 2020
Merged

Conversation

orchestr7
Copy link
Member

What's done:

  1. cosmetic changes in codestyle
  2. warnings enum extended
  3. small generator and test

### What's done:
1) cosmetic changes in codestyle
2) warnings enum extended
3) small generator and test
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #558 (f99b9dc) into master (205dbfc) will decrease coverage by 0.19%.
The diff coverage is 91.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #558      +/-   ##
============================================
- Coverage     81.88%   81.68%   -0.20%     
  Complexity     1641     1641              
============================================
  Files            78       79       +1     
  Lines          4129     4139      +10     
  Branches       1306     1307       +1     
============================================
  Hits           3381     3381              
- Misses          219      229      +10     
  Partials        529      529              
Flag Coverage Δ Complexity Δ
unittests 81.68% <91.15%> (-0.20%) 0.00 <2.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/kotlin/org/cqfn/diktat/common/cli/CliArgument.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...diktat/ruleset/constants/WarningsTableGenerator.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 98.31% <100.00%> (ø) 10.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205dbfc...f99b9dc. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the mapping table! Shouldn't we add to the README something like to quickly access inspection description, use rules-mapping.md? Or even write this line to the log when diktat is invoked?

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

### What's done:
Updated mapping for diktat
@orchestr7 orchestr7 merged commit 052bd9d into master Nov 23, 2020
@petertrr petertrr deleted the feature/warn-to-rule branch November 27, 2020 11:07
@petertrr petertrr added the documentation Improvements or additions to documentation label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants