-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding warnings to rules mapping in enum #558
Conversation
### What's done: 1) cosmetic changes in codestyle 2) warnings enum extended 3) small generator and test
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
============================================
- Coverage 81.88% 81.68% -0.20%
Complexity 1641 1641
============================================
Files 78 79 +1
Lines 4129 4139 +10
Branches 1306 1307 +1
============================================
Hits 3381 3381
- Misses 219 229 +10
Partials 529 529
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the mapping table! Shouldn't we add to the README something like to quickly access inspection description, use rules-mapping.md
? Or even write this line to the log when diktat is invoked?
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/WarningsTableGenerator.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/WarningsTableGenerator.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/WarningsTableGenerator.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/WarningsTableGenerator.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/utils/WarningsTest.kt
Outdated
Show resolved
Hide resolved
### What's done: Updated mapping for diktat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
### What's done: Updated mapping for diktat
What's done: