-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
White-paper table generator #568
Conversation
### What's done: Wrote parser
### What's done: Wrote parser
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=========================================
Coverage 80.73% 80.73%
Complexity 1790 1790
=========================================
Files 90 90
Lines 4702 4702
Branches 1423 1423
=========================================
Hits 3796 3796
Misses 321 321
Partials 585 585
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: Fixed available-rules.md
### What's done: Added library
### What's done: Renamed table names
fun main() { | ||
generateWarningNames() | ||
generateAvailableRules() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to move this logic away from Generation.kt
or even from diktat-rules. It feels not really needed to run this generators during every build, and for now it can be placed in a separate kts file in info
folder, near FullDocGenerator
. After that we have #592 to refactor it and make more concise.
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/Generation.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/Generation.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/Generation.kt
Outdated
Show resolved
Hide resolved
…rser # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/ConsecutiveSpacesRule.kt # diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/ConsecutiveSpacesRuleWarnTest.kt # info/available-rules.md # wp/sections/appendix.tex
### What's done: Fixed according our code-style
### What's done: Fixed according our code-style
### What's done: Fixed according our code-style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I can see, your generator only changes appendix.tex
, what are other changes in wp related files?
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/GenerationAvailableRules.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/GenerationAvailableRules.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed according our code-style
### What's done: Fixed according our code-style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's done: