Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White-paper table generator #568

Merged
merged 12 commits into from
Dec 16, 2020
Merged

White-paper table generator #568

merged 12 commits into from
Dec 16, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Nov 25, 2020

What's done:

Wrote parser

### What's done:
    Wrote parser
@kentr0w kentr0w added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 25, 2020
### What's done:
    Wrote parser
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #568 (443aa8a) into master (12af2ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #568   +/-   ##
=========================================
  Coverage     80.73%   80.73%           
  Complexity     1790     1790           
=========================================
  Files            90       90           
  Lines          4702     4702           
  Branches       1423     1423           
=========================================
  Hits           3796     3796           
  Misses          321      321           
  Partials        585      585           
Flag Coverage Δ Complexity Δ
unittests 80.73% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...kotlin/org/cqfn/diktat/ruleset/utils/LatexUtils.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12af2ac...443aa8a. Read the comment docs.

### What's done:
   Fixed available-rules.md
### What's done:
    Added library
### What's done:
    Renamed table names
fun main() {
generateWarningNames()
generateAvailableRules()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move this logic away from Generation.kt or even from diktat-rules. It feels not really needed to run this generators during every build, and for now it can be placed in a separate kts file in info folder, near FullDocGenerator. After that we have #592 to refactor it and make more concise.

…rser

# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/ConsecutiveSpacesRule.kt
#	diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/ConsecutiveSpacesRuleWarnTest.kt
#	info/available-rules.md
#	wp/sections/appendix.tex
### What's done:
   Fixed according our code-style
### What's done:
   Fixed according our code-style
### What's done:
   Fixed according our code-style
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I can see, your generator only changes appendix.tex, what are other changes in wp related files?

### What's done:
   Fixed according our code-style
### What's done:
   Fixed according our code-style
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentr0w kentr0w merged commit e37b89b into master Dec 16, 2020
@kentr0w kentr0w deleted the feature/wp-table-parser branch December 16, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants