-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diktat-analysis.yml can be read from a path, where jar is stored #588
Conversation
### What's done: Previously we were able to read 'diktat-analysis.yml' only from a path where ktlint is executed. Now it will also be read from jar file.
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
============================================
+ Coverage 80.74% 80.78% +0.04%
- Complexity 1703 1704 +1
============================================
Files 87 87
Lines 4346 4357 +11
Branches 1340 1342 +2
============================================
+ Hits 3509 3520 +11
+ Misses 299 298 -1
- Partials 538 539 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests on this?
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt
Outdated
Show resolved
Hide resolved
### What's done: Review notes
### What's done: Review notes
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt
Outdated
Show resolved
Hide resolved
Coverage is not decreasing. But, yes I guess that later I will add something like functional tests |
### What's done: Review notes
What's done:
Previously we were able to read 'diktat-analysis.yml' only from a path where ktlint is executed. Now it will also be read from jar file.