Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diktat-analysis.yml can be read from a path, where jar is stored #588

Merged
merged 6 commits into from
Nov 30, 2020

Conversation

orchestr7
Copy link
Member

What's done:

Previously we were able to read 'diktat-analysis.yml' only from a path where ktlint is executed. Now it will also be read from jar file.

### What's done:
Previously we were able to read 'diktat-analysis.yml' only from a path where ktlint is executed. Now it will also be read from jar file.
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #588 (293f0a5) into master (9cd02d7) will increase coverage by 0.04%.
The diff coverage is 76.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #588      +/-   ##
============================================
+ Coverage     80.74%   80.78%   +0.04%     
- Complexity     1703     1704       +1     
============================================
  Files            87       87              
  Lines          4346     4357      +11     
  Branches       1340     1342       +2     
============================================
+ Hits           3509     3520      +11     
+ Misses          299      298       -1     
- Partials        538      539       +1     
Flag Coverage Δ Complexity Δ
unittests 80.78% <76.47%> (+0.04%) 0.00 <5.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...lin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt 93.82% <33.33%> (+0.07%) 32.00 <1.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.64% <85.71%> (+0.31%) 9.00 <4.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd02d7...293f0a5. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests on this?

@orchestr7
Copy link
Member Author

Any tests on this?

Coverage is not decreasing. But, yes I guess that later I will add something like functional tests

@orchestr7 orchestr7 merged commit 11d2c4c into master Nov 30, 2020
@petertrr petertrr deleted the hotfix/diktat-config branch December 21, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants