Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: npe in IndentationRule #595

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

petertrr
Copy link
Member

What's done:

  • Fixed bug

This pull request closes #553

### What's done:
* Fixing code style
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #595 (1872a98) into master (4ce391a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #595      +/-   ##
============================================
+ Coverage     80.82%   80.84%   +0.02%     
  Complexity     1704     1704              
============================================
  Files            87       87              
  Lines          4365     4365              
  Branches       1345     1346       +1     
============================================
+ Hits           3528     3529       +1     
  Misses          297      297              
+ Partials        540      539       -1     
Flag Coverage Δ Complexity Δ
unittests 80.84% <100.00%> (+0.02%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../cqfn/diktat/ruleset/utils/indentation/Checkers.kt 78.21% <100.00%> (+0.99%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce391a...1872a98. Read the comment docs.

Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 2349037 into master Nov 30, 2020
@petertrr petertrr deleted the hotfix/npe-in-indentation#553 branch November 30, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments should be indented as the code they are commenting
2 participants