Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDoc check property in class #598

Merged
merged 10 commits into from
Dec 7, 2020
Merged

KDoc check property in class #598

merged 10 commits into from
Dec 7, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Dec 1, 2020

What's done:

Added new rule

closed #578

### What's done:
    Added new rule
@kentr0w kentr0w added the enhancement New feature or request label Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #598 (cf41f0a) into master (0af6e32) will decrease coverage by 0.05%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #598      +/-   ##
============================================
- Coverage     80.79%   80.73%   -0.06%     
- Complexity     1738     1746       +8     
============================================
  Files            89       89              
  Lines          4602     4614      +12     
  Branches       1378     1386       +8     
============================================
+ Hits           3718     3725       +7     
  Misses          322      322              
- Partials        562      567       +5     
Flag Coverage Δ Complexity Δ
unittests 80.73% <58.33%> (-0.06%) 0.00 <7.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt 79.68% <54.54%> (-2.37%) 70.00 <7.00> (+8.00) ⬇️
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 97.63% <100.00%> (+0.01%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af6e32...cf41f0a. Read the comment docs.

### What's done:
    Fixed after review
…rty-tag

# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt
#	diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/KdocCommentsWarnTest.kt
### What's done:
   Fixed according to out code-style
### What's done:
   Fixed according to out code-style
### What's done:
   Fixed according to out code-style
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentr0w kentr0w merged commit ac92d54 into master Dec 7, 2020
@kentr0w kentr0w deleted the feature/check-property-tag branch December 7, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KdocComments rule should check if all @property tag subjects are actually present in the class
2 participants