Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing diktat check workflows #613

Merged
merged 9 commits into from
Dec 7, 2020
Merged

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Dec 4, 2020

  • Use config from release for check by release version
  • Check all modules in snapshot check

This pull request closes #579

### What's done:
* Use config from release for check by release version
* Check all modules in snapshot check
### What's done:
* Use config from release for check by release version
* Check all modules in snapshot check
### What's done:
* Use config from release for check by release version
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #613 (768a46a) into master (4e16a72) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #613   +/-   ##
=========================================
  Coverage     81.21%   81.21%           
  Complexity     1738     1738           
=========================================
  Files            88       88           
  Lines          4574     4574           
  Branches       1371     1371           
=========================================
  Hits           3715     3715           
  Misses          308      308           
  Partials        551      551           
Flag Coverage Δ Complexity Δ
unittests 81.21% <100.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 76.19% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e16a72...768a46a. Read the comment docs.

### What's done:
* Fixing code style
### What's done:
* Update diktat.yml
### What's done:
* Update diktat.yml
### What's done:
* Update diktat.yml
@petertrr petertrr requested review from aktsay6 and kentr0w December 4, 2020 15:52
Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit ecfee94 into master Dec 7, 2020
@petertrr petertrr deleted the infra/diktat-workflows#579 branch December 7, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use default config for run diktat from release version workflow
2 participants