Feature/viktor guide review #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Edited the material and requested review.
…Viktor_Guide_Review � Conflicts: � info/guide/guide-chapter-1.md � info/guide/guide-chapter-2.md � info/guide/guide-chapter-3.md � info/guide/guide-chapter-4.md � info/guide/guide-chapter-6.md
### What's done: Review notes
…Viktor_Guide_Review
…Viktor_Guide_Review
### What's done: Edited the material and requested review.
…Viktor_Guide_Review
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
### What's done: Edited the material and requested review.
### What's done: Edited the material and requested review.
…Viktor_Guide_Review
### What's done: Edited the material and requested review.
…o feature/Viktor_Guide_Review # Conflicts: # info/guide/guide-chapter-1.md # info/guide/guide-chapter-2.md # info/guide/guide-chapter-3.md # info/guide/guide-chapter-4.md # info/guide/guide-chapter-6.md # info/guide/guide-chapter-8.md
orchestr7
commented
Dec 8, 2020
info/guide/guide-chapter-4.md
Outdated
| @@ -149,7 +152,7 @@ typealias Predicate<T> = (T) -> Boolean | |||
| ### <a name="c4.3"></a> 4.3 Null safety and variable declarations | |||
| Kotlin is declared as a null-safe programming language. However, to achieve compatibility with Java, it still supports nullable types. | |||
|
|
|||
| ### <a name="r4.3.1"></a> Recommendation 4.3.1: Avoid declaring variables with nullable types, especially from Kotlin stdlib. | |||
| #### <a name="s4.3.1"></a> Recommendation 4.3.1: Avoid declaring variables with nullable types, especially from Kotlin stdlib. | |||
There was a problem hiding this comment.
need to fix these things
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
============================================
- Coverage 80.85% 80.75% -0.10%
+ Complexity 1787 1748 -39
============================================
Files 90 89 -1
Lines 4690 4615 -75
Branches 1414 1386 -28
============================================
- Hits 3792 3727 -65
- Misses 318 322 +4
+ Partials 580 566 -14
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…Viktor_Guide_Review
### What's done: Edited the material and requested review.
orchestr7
commented
Dec 14, 2020
petertrr
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which rule and warnings did you add?
This pull request closes
Actions checklist
Fixme