Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP in AnnotationNewLineRule with comment #629

Merged
merged 14 commits into from
Dec 14, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Dec 9, 2020

What's done:

Fixed bug and added tests
closes #609

Fixme

The fix is ​​not working correctly.

### What's done:
   Fixed bug and added tests
@kentr0w kentr0w added the bug Something isn't working label Dec 9, 2020
@kentr0w kentr0w requested review from petertrr and aktsay6 December 9, 2020 18:11
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #629 (a6a7ec1) into master (cf7e9de) will decrease coverage by 0.08%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #629      +/-   ##
============================================
- Coverage     80.81%   80.73%   -0.09%     
  Complexity     1790     1790              
============================================
  Files            90       90              
  Lines          4691     4702      +11     
  Branches       1415     1423       +8     
============================================
+ Hits           3791     3796       +5     
- Misses          319      321       +2     
- Partials        581      585       +4     
Flag Coverage Δ Complexity Δ
unittests 80.73% <57.14%> (-0.09%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 82.97% <50.00%> (-1.85%) 0.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/AnnotationNewLineRule.kt 90.90% <100.00%> (ø) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7e9de...a6a7ec1. Read the comment docs.

### What's done:
   Fixed according out code-style
### What's done:
   Fixed according out code-style
### What's done:
   Fixed according out code-style
### What's done:
   Fixed according out code-style
### What's done:
   Fixed according out code-style
### What's done:
   Fixed according out code-style
### What's done:
   Fixed according out code-style
### What's done:
   Fixed after review
### What's done:
   Fixed after review
@kentr0w kentr0w merged commit 12af2ac into master Dec 14, 2020
@kentr0w kentr0w deleted the bugfix/FP-annotation-with-comment branch December 14, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP ANNOTATION_NEW_LINE when there is a comment after an annotation
2 participants