Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run functional tests on different OS #633

Merged
merged 21 commits into from
Dec 14, 2020
Merged

Run functional tests on different OS #633

merged 21 commits into from
Dec 14, 2020

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Dec 10, 2020 •
edited
Loading

What's done:

  • Split different diktat runners in functional_tests.yml
  • Specify ubuntu version explicitly
  • Functional tests are executed on different OS

Fixme:

  • remove diktat and ktlint versions from env in functional_tests.yml, they are actually taken from poms, and their existence there is confusing. Should use github actions' env vars file instead.

This pull request closes #626

@petertrr
Improvements for CI workflows
533e553 
### What's done:
* Split different diktat runners in functional_tests.yml
* Specify ubuntu version explicitly
@codecov
Copy link

codecov bot commented Dec 10, 2020 •
edited
Loading

Codecov Report

Merging #633 (fb80511) into master (27d1536) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #633   +/-   ##
=========================================
  Coverage     80.81%   80.81%           
  Complexity     1790     1790           
=========================================
  Files            90       90           
  Lines          4691     4691           
  Branches       1415     1415           
=========================================
  Hits           3791     3791           
  Misses          319      319           
  Partials        581      581
Flag Coverage Δ Complexity Δ
unittests 80.81% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d1536...fb80511. Read the comment docs.

@petertrr
Improvements for CI workflows
1934b98 
### What's done:
* matrix.os in functional_tests.yml
@petertrr
Improvements for CI workflows
c56da04 
### What's done:
* matrix.os in functional_tests.yml
@petertrr
Update functional_tests.yml
d772235
@petertrr
Update functional_tests.yml
0ef6318
@petertrr
Update functional_tests.yml
08f3ea6
@petertrr
Update functional_tests.yml
4524f1a
@petertrr
CI improvements
a8a4ddd 
### What's done:
* Removed explicit env vars from functional_tests.yml
@petertrr
CI improvements
c0aa74e 
### What's done:
* Removed explicit env vars from functional_tests.yml
@petertrr
Merge branch 'master' into infra/ci-refactoring#626
b538e1c
@petertrr
CI improvements
afe3524 
### What's done:
* Removed explicit env vars from functional_tests.yml
@petertrr
CI improvements
8d5d4c1 
### What's done:
* Removed explicit env vars from functional_tests.yml
@petertrr
CI improvements
b8607ac 
### What's done:
* Removed explicit env vars from functional_tests.yml
@petertrr
CI improvements
2da4f0c 
### What's done:
* Removed explicit env vars from functional_tests.yml
@petertrr
CI improvements
44cccd4 
### What's done:
* Removed explicit env vars from functional_tests.yml
@petertrr
CI improvements
dadfd72 
### What's done:
* Removed explicit env vars from functional_tests.yml
@petertrr
CI improvements
2d35864 
### What's done:
* Use cmd on windows
@petertrr
CI improvements
d2bfd51 
### What's done:
* Use cmd on windows
@petertrr
CI improvements
b34e3f1 
### What's done:
* Use cmd on windows
@petertrr
CI improvements
47825b0 
### What's done:
* Use cmd on windows
@petertrr petertrr changed the title Improvements for CI workflows Run functional tests on different OS Dec 11, 2020
@petertrr petertrr marked this pull request as ready for review December 11, 2020 15:04
aktsay6
aktsay6 reviewed Dec 14, 2020
View reviewed changes
.github/workflows/functional_tests.yml
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use ubuntu-latest, but previously we were using ubuntu-20.04?

Copy link
Member Author

@petertrr petertrr Dec 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't matter much, currently ubuntu-latest is 18.04, but github has already announced it will be changed to 20.04 soon. I thought that since I introduce other OS here, it will be easier to just use latest tag and not manage specific versions for all environments. And since diktat is a JVM application, it should run on all recent distros.

kentr0w
kentr0w approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit cf7e9de into master Dec 14, 2020
@petertrr petertrr deleted the infra/ci-refactoring#626 branch December 14, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktsay6 aktsay6 aktsay6 left review comments

@kentr0w kentr0w kentr0w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run CI tests on different OS
3 participants
@petertrr @kentr0w @aktsay6