Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitepaper Update #641

Merged
merged 7 commits into from
Dec 16, 2020
Merged

Whitepaper Update #641

merged 7 commits into from
Dec 16, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Dec 14, 2020

What's done:

  • Fixed bugs in GenerationDocs.kt
  • Updated wp

This pull request closes #640

### What's done:
  * Fixed bugs in GenerationDocs.kt
  * Updated wp
@aktsay6 aktsay6 added the documentation Improvements or additions to documentation label Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #641 (ed91995) into master (e37b89b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #641   +/-   ##
=========================================
  Coverage     80.73%   80.73%           
  Complexity     1790     1790           
=========================================
  Files            90       90           
  Lines          4702     4702           
  Branches       1423     1423           
=========================================
  Hits           3796     3796           
  Misses          321      321           
  Partials        585      585           
Flag Coverage Δ Complexity Δ
unittests 80.73% <0.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...kotlin/org/cqfn/diktat/ruleset/utils/LatexUtils.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37b89b...ed91995. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you update full code style via FullDocGenerator.kts?

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that full guide is updated too. All other changes look good.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your generator creates a file convention.tex. Is it actually used? I can see that now you append guide into appendix.

# Conflicts:
#	wp/sections/appendix.tex
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bug
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 merged commit 0728f36 into master Dec 16, 2020
@aktsay6 aktsay6 deleted the feature/wp-update branch December 16, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update whitepaper
2 participants