Bugfix. Newline rule rbrace(#617) #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Logic began
### What's done: * Added case for right brace
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
=========================================
Coverage 78.91% 78.91%
Complexity 1789 1789
=========================================
Files 88 88
Lines 4696 4696
Branches 1506 1506
=========================================
Hits 3706 3706
Misses 298 298
Partials 692 692
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixed bugs
### What's done: * Fixed bugs
petertrr
requested changes
Dec 21, 2020
| @@ -113,11 +116,58 @@ class NewlinesRule(private val configRules: List<RulesConfig>) : Rule("newlines" | |||
| BLOCK -> handleLambdaBody(node) | |||
| RETURN -> handleReturnStatement(node) | |||
| SUPER_TYPE_LIST, VALUE_PARAMETER_LIST -> handleList(node) | |||
| RBRACE -> handleRightBrace(node) | |||
There was a problem hiding this comment.
Shouldn't it be handled in BlockStructureBraces instead of NewlinesRule?
There was a problem hiding this comment.
Completly forgot about it. Remade bugfix
### What's done: * Fixed bugs
petertrr
approved these changes
Dec 21, 2020
| @@ -144,6 +143,7 @@ class DiktatRuleSetProvider(private var diktatConfigFile: String = DIKTAT_ANALYS | |||
| ::AvoidNestedFunctionsRule, | |||
| ::ExtensionFunctionsSameNameRule, | |||
| // formatting: moving blocks, adding line breaks, indentations etc. | |||
| ::BlockStructureBraces, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle of right brace case was added
This pull request closes #617