DataClassesRule shouldn't trigger when no property in constructor #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Fixed bug, added test
### What's done: Fixed code-style
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
============================================
- Coverage 79.17% 79.05% -0.12%
- Complexity 1811 1816 +5
============================================
Files 87 87
Lines 4724 4732 +8
Branches 1521 1525 +4
============================================
+ Hits 3740 3741 +1
- Misses 280 285 +5
- Partials 704 706 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: Fixed code-style
petertrr
requested changes
Dec 28, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/DataClassesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Added logic for empty class and class with property
### What's done: Fixed code-style
petertrr
requested changes
Dec 29, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/DataClassesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed code-style
### What's done: Fixed code-style
petertrr
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
closes DataClassesRule when class has non-properties in the constructor #666