Update ktlint.version from 0.39.0 to 0.43.0 #816

Cheshiriks · 2021-04-01T08:43:27Z

What's done:

Updates ktlint.version from 0.39.0 to 0.43.0
Increased minimum required gradle version to 5.3
Fix how file path is passed to Params in diktat-maven-plugin
gradle plugin with absolute paths doesn' work on Windows and Mac (windows - because of short directory names like C:\Users\MYUSER~1\... that can't be properly resolved in Java) - so forbid absolute path in gradle plugin
Disable standard ruleset in CLI test
Add tests for CLI execution with absolute paths

### What's done: * Updates ktlint.version from 0.39.0 to 0.41.0

petertrr · 2021-04-03T18:52:20Z

Looking at the tests, it seems that since gradle metadata has seen its first stable release in 5.3, we should increase a minimum required gradle version and increase the version in tests. 5.0, which we have now, is pretty outdated now anyway.
Btw, actual error is because class Bundling is available since 5.3.

petertrr · 2021-04-03T18:53:05Z

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/KotlinParser.kt

@@ -27,6 +27,7 @@ import sun.reflect.ReflectionFactory
 /**
 * A class that wraps kotlin compiler's code parser and converts source code into AST
 */
+@Suppress("EMPTY_BLOCK_STRUCTURE_ERROR")


Why? It should be fine with current snapshot

No, the project failed on this error

### What's done: * Updates ktlint.version from 0.39.0 to 0.41.0

codecov · 2021-04-05T15:07:55Z

Codecov Report

Merging #816 (ce196cf) into master (9fb026f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #816      +/-   ##
============================================
+ Coverage     83.74%   83.75%   +0.01%     
  Complexity     2433     2433              
============================================
  Files           102      102              
  Lines          6126     6132       +6     
  Branches       1820     1820              
============================================
+ Hits           5130     5136       +6     
  Misses          273      273              
  Partials        723      723

Flag	Coverage Δ
unittests	`83.75% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt	`100.00% <100.00%> (ø)`
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt	`89.02% <100.00%> (+0.56%)`	⬆️
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt	`74.13% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb026f...ce196cf. Read the comment docs.

### What's done: * Updates ktlint.version from 0.39.0 to 0.41.0

Cheshiriks · 2021-04-08T09:00:57Z

Now userData["file_path"] in Ktlint contains only file name. This makes full path not available for rules. Some tests also crashed

issue pinterest/ktlint#1133

orchestr7

It looks like we need to think about the move to the newest version of ktlint or some other framework, because diktat cli is working incorectly with ktlint 0.39 (not able to disable standard ruleset)

petertrr · 2021-07-30T07:58:01Z

@Cheshiriks ktlint 0.42.0 is out. Please update this PR, bump version and see, if any of our problems are solved in the new version (IIRC, file patterns should work better now)

# Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/Generation.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt # pom.xml

### What's done: * Update ktlint version

petertrr · 2021-08-04T17:00:35Z

We should also disable standard rulesetes in our test for CLI execution

### What's done: * Debug logging * Cleanup

### What's done: * Fix in maven plugin

### What's done: * Use snapshot version * Enable content filtering of gradle repos

### What's done: * Disable gradle tests with absolute paths on Windows * Add CLI tests with absolute paths

### What's done: * Revert changes related to snapshot ktlint * Update gradle to 7.2

### What's done: * Align version of kotlin plugin for gradle plugin with embedded kotlin into gradle * Code style

…ure/ktlint-0.41.0

### What's done: * Remove -Werror from diktat-gradle-plugin

### What's done: * Forbid usage of absolute paths in diktat-gradle-plugin

# Conflicts: # pom.xml

codecov-commenter · 2021-11-08T11:19:48Z

Codecov Report

Merging #816 (7ef53cf) into master (631c10e) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #816      +/-   ##
============================================
- Coverage     83.41%   83.40%   -0.02%     
  Complexity     2453     2453              
============================================
  Files           102      102              
  Lines          6137     6139       +2     
  Branches       1838     1839       +1     
============================================
+ Hits           5119     5120       +1     
  Misses          274      274              
- Partials        744      745       +1

Flag	Coverage Δ
unittests	`83.40% <66.66%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt	`88.46% <ø> (ø)`
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt	`70.17% <0.00%> (-1.76%)`	⬇️
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631c10e...7ef53cf. Read the comment docs.

### What's done: * Use ktlint fat jar from maven central, because the one at GH releases is broken

Cheshiriks force-pushed the feature/ktlint-0.41.0 branch from 0aa17be to b1ebfeb Compare April 2, 2021 16:08

Update ktlint.version from 0.39.0 to 0.41.0

90beb06

### What's done: * Updates ktlint.version from 0.39.0 to 0.41.0

Cheshiriks force-pushed the feature/ktlint-0.41.0 branch from b1ebfeb to 90beb06 Compare April 2, 2021 16:21

petertrr reviewed Apr 3, 2021

View reviewed changes

Update ktlint.version from 0.39.0 to 0.41.0

5b70a0f

### What's done: * Updates ktlint.version from 0.39.0 to 0.41.0

Cheshiriks force-pushed the feature/ktlint-0.41.0 branch from 4271158 to 5b70a0f Compare April 5, 2021 14:57

Merge branch 'master' into feature/ktlint-0.41.0

46e5e2d

Cheshiriks force-pushed the feature/ktlint-0.41.0 branch from bccbe07 to e5f9fb8 Compare April 6, 2021 10:03

Update ktlint.version from 0.39.0 to 0.41.0

a847269

### What's done: * Updates ktlint.version from 0.39.0 to 0.41.0

Cheshiriks force-pushed the feature/ktlint-0.41.0 branch from e5f9fb8 to a847269 Compare April 6, 2021 12:56

Merge branch 'master' into feature/ktlint-0.41.0

fc678e9

Cheshiriks force-pushed the feature/ktlint-0.41.0 branch 2 times, most recently from 8db36b6 to df40d26 Compare April 7, 2021 16:13

Update ktlint.version from 0.39.0 to 0.41.0

e0ce704

### What's done: * Updates ktlint.version from 0.39.0 to 0.41.0

Cheshiriks force-pushed the feature/ktlint-0.41.0 branch from df40d26 to e0ce704 Compare April 7, 2021 16:19

orchestr7 linked an issue Apr 26, 2021 that may be closed by this pull request

KtLint 0.40.0 has changed mechanism for file path loading, we face errors when .editorconfig is missing #616

Closed

orchestr7 mentioned this pull request Apr 26, 2021

KtLint 0.40.0 has changed mechanism for file path loading, we face errors when .editorconfig is missing #616

Closed

orchestr7 requested changes Jun 13, 2021

View reviewed changes

petertrr added 3 commits August 4, 2021 18:01

Merge remote-tracking branch 'origin/master' into feature/ktlint-0.41.0

6c5e964

# Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/Generation.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt # pom.xml

Update ktlint to 0.42.0

d5f7f9a

### What's done: * Update ktlint version

Update DiktatJavaExecTaskBase.kt

f83cda5

Update DiktatGradlePluginFunctionalTest.kt

a8b69ed

petertrr changed the title ~~Update ktlint.version from 0.39.0 to 0.41.0~~ Update ktlint.version from 0.39.0 to 0.42.0 Aug 5, 2021

petertrr added 2 commits August 5, 2021 10:14

Update ktlint to 0.42.0

fbb7c8c

### What's done: * Debug logging * Cleanup

Update ktlint to 0.42.0

44e82a1

### What's done: * Fix in maven plugin

petertrr added 3 commits August 9, 2021 11:55

Update ktlint to 0.43.0-SNAPSHOT

80d96ee

### What's done: * Use snapshot version * Enable content filtering of gradle repos

Update ktlint to 0.43.0-SNAPSHOT

651bb15

### What's done: * Use snapshot version * Enable content filtering of gradle repos

Update ktlint to 0.43.0-SNAPSHOT

d0e25da

### What's done: * Disable gradle tests with absolute paths on Windows * Add CLI tests with absolute paths

petertrr force-pushed the feature/ktlint-0.41.0 branch from 0073239 to d0e25da Compare August 9, 2021 09:44

Update ktlint to 0.43.0-SNAPSHOT

b615080

### What's done: * Disable gradle tests with absolute paths on Windows * Add CLI tests with absolute paths

petertrr force-pushed the feature/ktlint-0.41.0 branch from 9211cec to b615080 Compare August 9, 2021 11:07

petertrr added 3 commits August 9, 2021 16:51

Update ktlint to 0.43.0-SNAPSHOT

86e7ee8

### What's done: * Disable gradle tests with absolute paths on Windows * Add CLI tests with absolute paths

Try to use ktlint snapshot from sonatype

1c8bb38

Update build_and_test.yml

eba28f7

petertrr changed the title ~~Update ktlint.version from 0.39.0 to 0.42.0~~ Update ktlint.version from 0.39.0 to 0.43.0-SNAPSHOT Aug 23, 2021

petertrr added 2 commits August 23, 2021 16:48

Merge branch 'master' into feature/ktlint-0.41.0

ce196cf

Ktlint 0.43.0

f2bcb1c

### What's done: * Revert changes related to snapshot ktlint * Update gradle to 7.2

petertrr changed the title ~~Update ktlint.version from 0.39.0 to 0.43.0-SNAPSHOT~~ Update ktlint.version from 0.39.0 to 0.43.0 Nov 3, 2021

petertrr added 5 commits November 3, 2021 14:06

Merge branch 'master' into feature/ktlint-0.41.0

0392d3b

Ktlint 0.43.0

4ea2977

### What's done: * Align version of kotlin plugin for gradle plugin with embedded kotlin into gradle * Code style

Merge remote-tracking branch 'origin/feature/ktlint-0.41.0' into feat…

08bc71d

…ure/ktlint-0.41.0

Ktlint 0.43.0

319864a

### What's done: * Remove -Werror from diktat-gradle-plugin

Ktlint 0.43.0

18860c3

### What's done: * Forbid usage of absolute paths in diktat-gradle-plugin

petertrr force-pushed the feature/ktlint-0.41.0 branch from 16acb24 to 18860c3 Compare November 8, 2021 08:22

petertrr added 2 commits November 8, 2021 14:06

Ktlint 0.43.0

84004c1

### What's done: * Forbid usage of absolute paths in diktat-gradle-plugin

Merge remote-tracking branch 'origin/master' into feature/ktlint-0.41.0

3c41d30

# Conflicts: # pom.xml

orchestr7 marked this pull request as ready for review November 8, 2021 11:11

Ktlint 0.43

ca1941f

### What's done: * Use ktlint fat jar from maven central, because the one at GH releases is broken

orchestr7 approved these changes Nov 8, 2021

View reviewed changes

petertrr added 3 commits November 8, 2021 14:41

Update build_and_test.yml

a4c61b9

Merge branch 'master' into feature/ktlint-0.41.0

86a7d3e

Ktlint 0.43

7ef53cf

### What's done: * Use ktlint fat jar from maven central, because the one at GH releases is broken

petertrr merged commit 45f91c9 into master Nov 8, 2021

petertrr deleted the feature/ktlint-0.41.0 branch November 8, 2021 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ktlint.version from 0.39.0 to 0.43.0 #816

Update ktlint.version from 0.39.0 to 0.43.0 #816

Cheshiriks commented Apr 1, 2021 •

edited by petertrr

Loading

petertrr commented Apr 3, 2021

petertrr Apr 3, 2021

Cheshiriks Apr 4, 2021

codecov bot commented Apr 5, 2021 •

edited

Loading

Cheshiriks commented Apr 8, 2021 •

edited

Loading

orchestr7 left a comment

petertrr commented Jul 30, 2021

petertrr commented Aug 4, 2021

codecov-commenter commented Nov 8, 2021 •

edited by codecov bot

Loading

Update ktlint.version from 0.39.0 to 0.43.0 #816

Update ktlint.version from 0.39.0 to 0.43.0 #816

Conversation

Cheshiriks commented Apr 1, 2021 • edited by petertrr Loading

What's done:

petertrr commented Apr 3, 2021

petertrr Apr 3, 2021

Choose a reason for hiding this comment

Cheshiriks Apr 4, 2021

Choose a reason for hiding this comment

codecov bot commented Apr 5, 2021 • edited Loading

Codecov Report

Cheshiriks commented Apr 8, 2021 • edited Loading

orchestr7 left a comment

Choose a reason for hiding this comment

petertrr commented Jul 30, 2021

petertrr commented Aug 4, 2021

codecov-commenter commented Nov 8, 2021 • edited by codecov bot Loading

Codecov Report

Cheshiriks commented Apr 1, 2021 •

edited by petertrr

Loading

codecov bot commented Apr 5, 2021 •

edited

Loading

Cheshiriks commented Apr 8, 2021 •

edited

Loading

codecov-commenter commented Nov 8, 2021 •

edited by codecov bot

Loading