-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for actual warning in SAVE from the file #366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's done: * Added reading of actual warning from the file
kgevorkyan
reviewed
Feb 17, 2022
@Cheshiriks Please remind what's the problem was with this PR and could it be continued? |
kgevorkyan
reviewed
Jan 23, 2023
examples/kotlin-diktat/sarif-actual-expected/save-warnings-actual.sarif
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #366 +/- ##
============================================
- Coverage 47.50% 47.46% -0.05%
- Complexity 158 159 +1
============================================
Files 53 53
Lines 1846 1852 +6
Branches 316 316
============================================
+ Hits 877 879 +2
- Misses 837 840 +3
- Partials 132 133 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kgevorkyan
reviewed
Jan 23, 2023
save-plugins/warn-plugin/src/commonMain/kotlin/com/saveourtool/save/plugin/warn/WarnPlugin.kt
Outdated
Show resolved
Hide resolved
### What's done: * refactoringgit
…eature/test-for-actual
nulls
approved these changes
Jan 23, 2023
kgevorkyan
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: