-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt FixPlugin for library for applying of SARIF fix patches #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save-common/src/commonMain/kotlin/com/saveourtool/save/core/config/FixFormats.kt
Fixed
Show fixed
Hide fixed
...arn-plugin/src/commonMain/kotlin/com/saveourtool/save/plugins/fixandwarn/FixAndWarnPlugin.kt
Fixed
Show fixed
Hide fixed
...plugins/fix-plugin/src/commonMain/kotlin/com/saveourtool/save/plugins/fix/FixPluginConfig.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
============================================
- Coverage 47.77% 47.70% -0.08%
- Complexity 147 149 +2
============================================
Files 52 53 +1
Lines 1779 1790 +11
Branches 308 313 +5
============================================
+ Hits 850 854 +4
- Misses 803 807 +4
- Partials 126 129 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
orchestr7
reviewed
Dec 2, 2022
save-common/src/commonMain/kotlin/com/saveourtool/save/core/config/FixFormats.kt
Show resolved
Hide resolved
orchestr7
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
FixAndWarnPlugin use FixPlugin for fixing test files and comparing with expected, which are released of warnings at the moment of FixPlugin start, so there is no need to make changes in
FixAndWarnPlugin