Upgraded kotlin to 1.9.20 #556

nulls · 2023-11-08T15:00:07Z

What's done:

upgraded kotlin
removed actual\expected class
added required OptIn
removed nonJs target

It handles of #554
It closes #555

### WHat's done: - upgraded kotlin - removed actual\expected class - added required OptIn It handles of #554

save-common/src/nativeMain/kotlin/com/saveourtool/save/core/utils/PlatformUtils.kt

codecov · 2023-11-08T15:18:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.07%. Comparing base (58b524b) to head (7a40ae9).

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #556   +/-   ##
=========================================
  Coverage     48.07%   48.07%           
  Complexity      163      163           
=========================================
  Files            53       53           
  Lines          1893     1893           
  Branches        316      313    -3     
=========================================
  Hits            910      910           
  Misses          853      853           
  Partials        130      130

Flag	Coverage Δ
unittests	`48.07% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

save-common/src/nativeMain/kotlin/com/saveourtool/save/core/utils/ProcessBuilderInternal.kt

save-common/src/jvmMain/kotlin/com/saveourtool/save/core/utils/ProcessBuilderInternal.kt

save-common/src/commonMain/kotlin/com/saveourtool/save/core/utils/ProcessBuilder.kt

github-actions · 2023-11-08T15:51:04Z

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

245 tests ±0 221 ✔️ ±0 9m 4s ⏱️ + 1m 40s
  48 suites ±0   24 💤 ±0
  48 files ±0     0 ❌ ±0

Results for commit 22f3264. ± Comparison against base commit 119636c.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-08T15:51:21Z

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

245 tests ±0 221 ✔️ ±0 9m 34s ⏱️ -11s
  48 suites ±0   24 💤 ±0
  48 files ±0     0 ❌ ±0

Results for commit 22f3264. ± Comparison against base commit 119636c.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-08T15:51:43Z

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

245 tests ±0 221 ✔️ ±0 9m 12s ⏱️ - 3m 54s
  48 suites ±0   24 💤 ±0
  48 files ±0     0 ❌ ±0

Results for commit 22f3264. ± Comparison against base commit 119636c.

♻️ This comment has been updated with latest results.

save-common/src/jsMain/kotlin/com/saveourtool/save/core/utils/ProcessBuilder.kt

save-cli/src/nativeMain/kotlin/com/saveourtool/save/cli/logging/Logger.kt

save-cli/src/jvmMain/kotlin/com/saveourtool/save/cli/logging/Logger.kt

buildSrc/src/main/kotlin/com/saveourtool/save/buildutils/kotlin-library.gradle.kts

save-common/build.gradle.kts

buildSrc/src/main/kotlin/com/saveourtool/save/buildutils/kotlin-library.gradle.kts

orchestr7

Looks like you missed my comment. We do not have time for this now. Please focus on the priorities.
#554 (review)

nulls · 2023-11-10T13:43:14Z

Looks like you missed my comment. We do not have time for this now. Please focus on the priorities. #554 (review)

please block this PR too

orchestr7 · 2023-11-10T13:45:42Z

Looks like you missed my comment. We do not have time for this now. Please focus on the priorities. #554 (review)

please block this PR too

It's done already, I thought. Why block if it's done already?

nulls · 2023-11-10T14:16:26Z

Looks like you missed my comment. We do not have time for this now. Please focus on the priorities. #554 (review)

please block this PR too

It's done already, I thought. Why block if it's done already?

Because it will required to upgrade in save-cloud where we use snapshot version of save-cli.

Upgraded kotlin to 1.9.20

5ab159a

### WHat's done: - upgraded kotlin - removed actual\expected class - added required OptIn It handles of #554

nulls self-assigned this Nov 8, 2023

github-advanced-security bot found potential problems Nov 8, 2023

View reviewed changes

save-common/src/nativeMain/kotlin/com/saveourtool/save/core/utils/PlatformUtils.kt Fixed Show fixed Hide fixed

refactored ProcessBuilderInternal

1234397

github-advanced-security bot found potential problems Nov 8, 2023

View reviewed changes

diktatFix

c6c58c0

kgevorkyan reviewed Nov 9, 2023

View reviewed changes

save-common/src/jsMain/kotlin/com/saveourtool/save/core/utils/ProcessBuilder.kt Show resolved Hide resolved

nulls added 3 commits November 9, 2023 12:08

removed commonNonJs

f5a335a

diktatFix + moved commonNonJsTest

f3884f1

renamed JsName

d4f469c

github-advanced-security bot found potential problems Nov 9, 2023

View reviewed changes

save-cli/src/nativeMain/kotlin/com/saveourtool/save/cli/logging/Logger.kt Fixed Show fixed Hide fixed

save-cli/src/jvmMain/kotlin/com/saveourtool/save/cli/logging/Logger.kt Fixed Show fixed Hide fixed

nulls added 8 commits November 9, 2023 12:50

diktatFix

186a752

renamed commonNonJsTest in commonTest

f394441

exclude JS test for Processor Builder

9cb8daf

added dependencies for kotlin-test-js

0cb8c1c

update exclude patterns -- all tests are failing on JS

c52af88

re-used fs

8c67300

re-used fs

a20db9e

fixed test exclusion

e030524

nulls marked this pull request as ready for review November 9, 2023 12:37

nulls requested review from kgevorkyan, icemachined, Cheshiriks, orchestr7 and 0x6675636b796f75676974687562 November 9, 2023 12:38

Cheshiriks approved these changes Nov 9, 2023

View reviewed changes

kgevorkyan reviewed Nov 9, 2023

View reviewed changes

buildSrc/src/main/kotlin/com/saveourtool/save/buildutils/kotlin-library.gradle.kts Show resolved Hide resolved

save-common/build.gradle.kts Show resolved Hide resolved

kgevorkyan reviewed Nov 9, 2023

View reviewed changes

buildSrc/src/main/kotlin/com/saveourtool/save/buildutils/kotlin-library.gradle.kts Show resolved Hide resolved

added comments

0c7b6e2

orchestr7 approved these changes Nov 10, 2023

View reviewed changes

Merge branch 'main' into feature/upgrade-1.9.20#554

22f3264

nulls mentioned this pull request Nov 20, 2023

chore(deps): update all non-major dependencies (except core kotlin) #559

Merged

1 task

0x6675636b796f75676974687562 approved these changes Dec 1, 2023

View reviewed changes

kgevorkyan mentioned this pull request Feb 14, 2024

Updating Sarif and removing github okio #565

Merged

Merge branch 'main' into feature/upgrade-1.9.20#554

7a40ae9

nulls enabled auto-merge (squash) February 28, 2024 13:19

nulls merged commit 87b2d42 into main Feb 28, 2024
13 checks passed

nulls deleted the feature/upgrade-1.9.20#554 branch February 28, 2024 13:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgraded kotlin to 1.9.20 #556

Upgraded kotlin to 1.9.20 #556

nulls commented Nov 8, 2023 •

edited

Loading

codecov bot commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

orchestr7 left a comment

nulls commented Nov 10, 2023

orchestr7 commented Nov 10, 2023

nulls commented Nov 10, 2023

Upgraded kotlin to 1.9.20 #556

Upgraded kotlin to 1.9.20 #556

Conversation

nulls commented Nov 8, 2023 • edited Loading

What's done:

codecov bot commented Nov 8, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 8, 2023 • edited Loading

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

github-actions bot commented Nov 8, 2023 • edited Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

github-actions bot commented Nov 8, 2023 • edited Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

orchestr7 left a comment

Choose a reason for hiding this comment

nulls commented Nov 10, 2023

orchestr7 commented Nov 10, 2023

nulls commented Nov 10, 2023

nulls commented Nov 8, 2023 •

edited

Loading

codecov bot commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading