Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for TestSuiteSelector and TestSuiteSourceCreationComponent #1091

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

sanyavertolet
Copy link
Member

@sanyavertolet sanyavertolet commented Aug 23, 2022

This PR closes #1079

What's done:

  • Added (returned back) testSuiteSelector for general tests - all the avaliable ones
  • Fixed an issue with TestSuiteSelector in browser mode - now input form is cleared when an entity from avaliable list is chosen
  • Fixed an issue with unclosing modal - now when TestSuiteSource is successfully created, a new request for a fetch is sent

### What's done:
 * Added (returned back) testSuiteSelector for general tests - all the avaliable ones
 * Fixed an issue with TestSuiteSelector in browser mode - now input form is cleared when an entity from avaliable list is chosen
 * Fixed an issue with unclosing modal - now when TestSuiteSource is successfully created, a new request for a fetch is sent

 (#1079)
@sanyavertolet sanyavertolet added the frontend Tasks on frontend label Aug 23, 2022
@sanyavertolet sanyavertolet self-assigned this Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1091 (9719041) into master (3147930) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1091      +/-   ##
============================================
- Coverage     43.78%   43.65%   -0.13%     
  Complexity      562      562              
============================================
  Files           176      176              
  Lines          5338     5344       +6     
  Branches        506      506              
============================================
- Hits           2337     2333       -4     
- Misses         2819     2829      +10     
  Partials        182      182              
Impacted Files Coverage Δ
.../backend/controllers/TestSuitesSourceController.kt 6.52% <0.00%> (-0.15%) ⬇️
...ol/save/backend/service/TestSuitesSourceService.kt 70.31% <0.00%> (-1.12%) ⬇️
...mponents/basic/TestSuiteSourceCreationComponent.kt 0.00% <0.00%> (ø)
...ponents/basic/contests/ContestCreationComponent.kt 0.00% <ø> (ø)
...nents/basic/testsuiteselector/TestSuiteSelector.kt 0.00% <ø> (ø)
.../testsuiteselector/TestSuiteSelectorBrowserMode.kt 0.00% <0.00%> (ø)
...otlin/com/saveourtool/save/frontend/utils/Utils.kt 0.00% <0.00%> (-33.34%) ⬇️
...ve/frontend/components/basic/ManageUserRoleCard.kt 40.42% <0.00%> (-4.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sanyavertolet sanyavertolet enabled auto-merge (squash) August 23, 2022 13:54
@sanyavertolet sanyavertolet merged commit 528314e into master Aug 23, 2022
@sanyavertolet sanyavertolet deleted the bugfix/small_fixes_for_selectors branch August 23, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Tasks on frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix small selector issues
2 participants