Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContestSummaryMenu improvements #1108

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

sanyavertolet
Copy link
Member

This PR is connected with #1035

What's done:

  • Slightly improved ContestSummaryMenu
  • Fixed styles for execution labels for non-contest executions.

How it looks:

screenshot

### What's done:
 * Slightly improved `ContestSummaryMenu`
 * Fixed styles for execution labels for non-contest executions.

(#1035)
@sanyavertolet sanyavertolet added the frontend Tasks on frontend label Aug 26, 2022
@sanyavertolet sanyavertolet self-assigned this Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1108 (aeaea9c) into master (2129944) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1108      +/-   ##
============================================
- Coverage     43.32%   43.30%   -0.03%     
  Complexity      559      559              
============================================
  Files           177      177              
  Lines          5364     5367       +3     
  Branches        503      503              
============================================
  Hits           2324     2324              
- Misses         2857     2860       +3     
  Partials        183      183              
Impacted Files Coverage Δ
.../save/frontend/components/basic/ExecutionLabels.kt 33.33% <0.00%> (-1.15%) ⬇️
...nd/components/basic/contests/ContestSummaryMenu.kt 0.00% <0.00%> (ø)
.../frontend/components/views/ContestExecutionView.kt 0.00% <ø> (ø)
...ol/save/frontend/components/views/ExecutionView.kt 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sanyavertolet sanyavertolet enabled auto-merge (squash) August 26, 2022 14:07
### What's done:
 * Slightly improved `ContestSummaryMenu`
 * Fixed styles for execution labels for non-contest executions.

(#1035)
…vements' into feature/contestsummarymenu_improvements

# Conflicts:
#	save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/basic/contests/ContestSummaryMenu.kt
@sanyavertolet sanyavertolet merged commit 64470c7 into master Aug 26, 2022
@sanyavertolet sanyavertolet deleted the feature/contestsummarymenu_improvements branch August 26, 2022 14:54
nulls pushed a commit that referenced this pull request Aug 29, 2022
### What's done:
 * Slightly improved `ContestSummaryMenu`
 * Fixed styles for execution labels for non-contest executions.

(#1035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Tasks on frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants