Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating: phase 0.5. TestingType, best_execution in lnk_contest_project #1142

Merged
merged 18 commits into from
Sep 5, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Sep 2, 2022

  • Change ExecutionType to TestingType, pass testingType from the frontend
  • Add columns for best execution and best score in lnk_contest_project

What's left for phase 1:

  • Move score into Execution
  • Add creation of LnkProjectExecutions

First part of #1115

kgevorkyan and others added 8 commits August 29, 2022 15:41
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
# Conflicts:
#	save-cloud-common/src/jvmMain/kotlin/com/saveourtool/save/entities/Execution.kt
#	save-cloud-common/src/jvmMain/kotlin/com/saveourtool/save/entities/LnkContestProject.kt
* Add changeset
* Change mapping `ManyToOne` -> `OneToOne`
* Remove debug data
@petertrr petertrr changed the title [WIP] Feature/rating [WIP] Rating: phase 1 Sep 2, 2022
@petertrr petertrr changed the title [WIP] Rating: phase 1 [WIP] Rating: phase 0.5 Sep 2, 2022
@petertrr petertrr changed the title [WIP] Rating: phase 0.5 Rating: phase 0.5. TestingType, best_execution in lnk_contest_project Sep 5, 2022
@petertrr petertrr marked this pull request as ready for review September 5, 2022 08:12
@petertrr petertrr requested review from nulls and orchestr7 September 5, 2022 08:16
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1142 (874dec7) into master (c236a75) will decrease coverage by 0.09%.
The diff coverage is 70.00%.

❗ Current head 874dec7 differs from pull request most recent head 7a9e29a. Consider uploading reports for the commit 7a9e29a to get more accurate results

@@             Coverage Diff              @@
##             master    #1142      +/-   ##
============================================
- Coverage     43.09%   43.00%   -0.10%     
  Complexity      561      561              
============================================
  Files           179      179              
  Lines          5355     5360       +5     
  Branches        518      518              
============================================
- Hits           2308     2305       -3     
- Misses         2861     2869       +8     
  Partials        186      186              
Impacted Files Coverage Δ
...backend/controllers/LnkContestProjectController.kt 7.77% <ø> (ø)
...l/save/backend/service/LnkContestProjectService.kt 15.78% <0.00%> (ø)
...rontend/components/basic/TestResourcesSelection.kt 0.00% <ø> (ø)
...tool/save/frontend/components/views/ProjectView.kt 18.64% <0.00%> (ø)
...veourtool/save/backend/service/ExecutionService.kt 78.94% <66.66%> (-0.63%) ⬇️
...e/backend/controllers/CloneRepositoryController.kt 94.02% <100.00%> (+0.18%) ⬆️
...save/backend/controllers/RunExecutionController.kt 72.72% <100.00%> (+0.27%) ⬆️
...otlin/com/saveourtool/save/frontend/utils/Utils.kt 0.00% <0.00%> (-33.34%) ⬇️
...ts/basic/organizations/ManageGitCredentialsCard.kt 69.23% <0.00%> (-7.70%) ⬇️
...ntend/components/basic/projects/ProjectInfoMenu.kt 81.25% <0.00%> (-6.25%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@petertrr petertrr enabled auto-merge (squash) September 5, 2022 08:57
@petertrr petertrr merged commit 0cd2e5c into master Sep 5, 2022
@petertrr petertrr deleted the feature/rating branch September 5, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants