Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fixed multiple issues to support the httpd reverse proxy on Ubuntu … #34

Closed
wants to merge 1 commit into from

Conversation

drivard
Copy link

@drivard drivard commented Oct 23, 2017

…16.04 OS. The main issue was that the playbook was specific to CentOS/RedHat OS family. I introduced two files which are included dynamically by the ansible_os_family variable in the httpd_reverse_proxy_config.yml file. It is determining the OS familly and then it will set the proper package name to use between httpd for RedHat and apache2 for Debian.

  • Added the support for using an SSL certificate which is already existing on the file system of the nexus server without the need to copy the file from this role. In our case it is usefull because we combine it with a role obtaining a LetsEncrypt SSL certificate. Therefore if the httpd_copy_ssl_files which is by default set to true is overriden with a value of false you have to specify the location of the private key and certificate file on the remote server, then the nexus_vhost.conf template will be written with the location path of these files.

…16.04 OS. The main issue was that the playbook was specific to CentOS/RedHat OS family. I introduced two files which are included dynamically by the `ansible_os_family` variable in the `httpd_reverse_proxy_config.yml` file. It is determining the OS familly and then it will set the proper package name to use between `httpd` for RedHat and `apache2` for Debian.

- Added the support for using an SSL certificate which is already existing on the file system of the nexus server without the need to copy the file from this role. In our case it is usefull because we combine it with a role obtaining a LetsEncrypt SSL certificate. Therefore if the `httpd_copy_ssl_files` which is by default set to true is overriden with a value of false you have to specify the location of the private key and certificate file on the remote server, then the `nexus_vhost.conf` template will be written with the location path of these files.
@zeitounator
Copy link
Contributor

Hi @drivard,

As you may have seen in #36 and #38, the maintenance of this repo has been discontinued.

As a consequence, and after waiting for a response of the authors and suggestions from other contributors, I decided to fork the repo to go on with maintenance. You can find the new repo there: https://github.com/ansible-ThoTeam/nexus3-oss

I already integrated this current pull request as well as many other things among which travis integration for CI and testing. You're more than welcome to join and contribute if you have time and other contributions to propose. I'm also looking for good willing people for code reviews, writing more tests, documenting, preparing new releases/merges. Drop me an email (link on my github profile page) if you wish to get involved.

Cheers.

@drivard
Copy link
Author

drivard commented Dec 6, 2017

Thanks for accepting my PR, I will from now on use this repo and if I need to add feature I will be pleased to contribute new PRs.

Regards
Dominick

@drivard drivard closed this May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants