Shellcheck first pass #146
Conversation
|
What your opinion in making |
|
Yes I was wondering how much is that important since cqfd is meant to run with bash. Maybe @deribaucourt has an opinion on that ? |
I really like using shellcheck, I learnt a lot from it in the past by making all my shell scripts compliant to shellcheck. It solves lots of unexpected behaviors, especially concerning the globing or the preservation of whitspaces, and it helped me to write (way) better shell script. So I strongly suggest to start using it. |
|
I also think Shellcheck would be a great addition to the CI. Allows to catch minute bugs and improve code cleanliness |
gportay
force-pushed
the
shellcheck-first-pass
branch
from
0405e54 to
9f96324
Compare
|
@gportay Can you rebase to fix conflicts? Thanks for your contributions! |
sure I will do. |
The properties have their own global variable that are prefixed by their section; every properties at the exception of custom_img_name (from section project). This adds and uses the new global variable project_custom_img_name.
This fixes the trivial shellcheck errors and ignores the others.
gportay
force-pushed
the
shellcheck-first-pass
branch
from
9f96324 to
61a81ef
Compare
|
Looks very nice |
|
should we merge that now or better wait for "cqfd 6" ? |
|
Now is fine. |
This is a first pass of shellcheck fixes.
It fixes the trivial errors and disables the more tricky ones for now.