Fix: SymbolScanner fail to read URLs on Windows #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecodeURIComponent to decode Windows URLs
|
are we sure we want to think about Windows? I am quite sure we've been told we did not have to |
deribaucourt
approved these changes
Oct 17, 2023
The focus is Linux hosts right now as you can only run bitbake on Linux. Maybe add a comment anywhere there's a Linux assumption, like line endings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a read file error on Windows, so I made the following changes:
throwin thecatchblock because the upper call stack doesn't handle it.decodeURIComponentto decode URLs. This will correctly decode Windows URLs (e.g.d%3A/folder->d:/folder)From my understanding of this SymbolScanner, some functionalities could be moved to the Analyzer (tree-sitter). For now, let's keep it as is.