Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion items for operators and variable flags #35

Merged

Conversation

WilsonZiweiWang
Copy link
Collaborator

Override syntax completion will be triggered by typing : and variable flag completion will be triggered by typing [ as long as they follow an identifier which is a type defined by the tree-sitter-bitbake.

Only a list of minimum items is added as I didn't find the complete docs for them. The mechanics of adding completion items are ready for review.

sample result:
image
image

@WilsonZiweiWang WilsonZiweiWang self-assigned this Oct 24, 2023
@WilsonZiweiWang WilsonZiweiWang added the enhancement New feature or request label Oct 24, 2023
@WilsonZiweiWang WilsonZiweiWang force-pushed the Feature-10095-Improve-code-completion-overrides-flags branch from a75103d to 3f26719 Compare October 25, 2023 15:09
@WilsonZiweiWang WilsonZiweiWang marked this pull request as ready for review October 25, 2023 15:12
Copy link
Member

@idillon-sfl idillon-sfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

server/src/completions/variable-flags.ts Show resolved Hide resolved
server/src/connectionHandlers/onCompletion.ts Show resolved Hide resolved
@WilsonZiweiWang WilsonZiweiWang force-pushed the Feature-10095-Improve-code-completion-overrides-flags branch from 3f26719 to cf17123 Compare October 25, 2023 20:40
server/src/completions/overrides.ts Outdated Show resolved Hide resolved
server/src/completions/overrides.ts Outdated Show resolved Hide resolved
server/src/completions/variable-flags.ts Outdated Show resolved Hide resolved
@WilsonZiweiWang WilsonZiweiWang force-pushed the Feature-10095-Improve-code-completion-overrides-flags branch from cf17123 to 2ee4005 Compare October 26, 2023 18:12
@WilsonZiweiWang WilsonZiweiWang force-pushed the Feature-10095-Improve-code-completion-overrides-flags branch from 2ee4005 to c20233d Compare October 26, 2023 19:13
@WilsonZiweiWang WilsonZiweiWang changed the title Add completion items for overrides and variable flags Add completion items for operators and variable flags Oct 26, 2023
@deribaucourt
Copy link
Member

Looks good!

@WilsonZiweiWang WilsonZiweiWang merged commit ed4f06a into staging Oct 27, 2023
@deribaucourt deribaucourt deleted the Feature-10095-Improve-code-completion-overrides-flags branch November 2, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants