forked from yoctoproject/vscode-bitbake
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completion items for operators and variable flags #35
Merged
WilsonZiweiWang
merged 3 commits into
staging
from
Feature-10095-Improve-code-completion-overrides-flags
Oct 27, 2023
Merged
Add completion items for operators and variable flags #35
WilsonZiweiWang
merged 3 commits into
staging
from
Feature-10095-Improve-code-completion-overrides-flags
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a75103d
to
3f26719
Compare
idillon-sfl
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
3f26719
to
cf17123
Compare
deribaucourt
requested changes
Oct 26, 2023
cf17123
to
2ee4005
Compare
2ee4005
to
c20233d
Compare
Looks good! |
deribaucourt
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override syntax completion will be triggered by typing
:
and variable flag completion will be triggered by typing[
as long as they follow anidentifier
which is a type defined by the tree-sitter-bitbake.Only a list of minimum items is added as I didn't find the complete docs for them. The mechanics of adding completion items are ready for review.
sample result:
![image](https://private-user-images.githubusercontent.com/47988425/277787756-06741304-2f31-4347-8d62-a596d34a42f0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODU3NDcsIm5iZiI6MTczOTU4NTQ0NywicGF0aCI6Ii80Nzk4ODQyNS8yNzc3ODc3NTYtMDY3NDEzMDQtMmYzMS00MzQ3LThkNjItYTU5NmQzNGE0MmYwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAyMTA0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU0NmU3Y2M5N2JhM2JlMDJjMDBmMGM0ZGE1OWE5OTA3ZDgwZjY4YzcwOWE4YTdlYmQxYTkyY2QzMjU2NTQ5NTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Bwd1r8bj22Y_pg5xRDkRzwuTK0gOdnZlG_9d2ayhn6M)
![image](https://private-user-images.githubusercontent.com/47988425/277787890-51d52da1-d60b-4570-ab4d-763ee16982da.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODU3NDcsIm5iZiI6MTczOTU4NTQ0NywicGF0aCI6Ii80Nzk4ODQyNS8yNzc3ODc4OTAtNTFkNTJkYTEtZDYwYi00NTcwLWFiNGQtNzYzZWUxNjk4MmRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAyMTA0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk5Mzc4YzQ2YjdjNzVlZTJhMTIwODNkNjkyYzBlNzNhNjA0MWJiMmNjYTZhMzNjZWRjNjAyOTQ2NTFjMmQ3M2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.sT26nvv6-hnTawBe-i--GopQbk3X9xmppgMS3av38do)