Problems refactor #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deribaucourt
force-pushed
the
problems-refactor
branch
from
8c020dc to
ed8ebce
Compare
idillon-sfl
approved these changes
Nov 8, 2023
More exports will be added to this file in the next commits.
This commit adds a task to run bitbake in parse only mode. It can be triggered from the command prompt. In the next commits, the server code that replicates this will be refactored into using this task as well. It provides a more complete diagnosis problem matching.
The language server had a duplicated implementation of the parse task and problems matching. Through a request, use the one from the client. Launching the task returns the child execution, but not the command output, so we don't have access to the return value anymore. This doesn't cause any errors and actually allows to scan the project even if some recipes are broken. We now will keep access to the list of recipes and overrides in those cases.
This layer can be used to induce parsing errors during integration tests.
Parsing is no more done at the server level but through a command. Update the tests to reflect this change.
The diagnostics are asynchronously updated, so we need to wait for them to be updated before checking them.
Tasks are copied to temporary script so we don't have the original line numbers. Still, it's useful to report the error to the problems view.
If the user doesn't want/cannot configure bitbake to be run, it will be annoying to get errors on every save.
If the bitbake settings are obviously wrong, don't try to parse and generate more errors. A notification will already be issued.
This allows detecting the ParseErrors originating in layer.conf files.
deribaucourt
force-pushed
the
problems-refactor
branch
from
02b0ff8 to
ca37771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems where duplicated between language server parsing and client build commands. They are now no longer duplicated and share the same implementation.