-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitbake recipe view #60
Conversation
585149d
to
f422fe5
Compare
01c527d
to
ac96167
Compare
done() | ||
}) | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about these esling-disable. Do they have purpose,how you just forgot to remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of them are required and valid exceptions to some eslint rules.
This one in particular is gone with one of your other suggestions being implemented.
@WilsonZiweiWang It takes the file from the bitbake settings. Can you share a screenshot of your workspace configuration for the bitbake extension? |
8f912da
to
5d5c9e5
Compare
This new activity panel will allow users to quickly see the list of recipes in the current workspace. More features will be added in this PR.
In order not to collide with the BitbakeProjectScanner might use for representing recipes.
We'll need to share the scan results with the language client extension. Prepare for this by moving the types into the common library.
A language server notification is now emitted to the client. It will be possible to use the scan results to populate the Bitbake recipes view.
Using the results from the bitbake scan, display the main recipe source file in the recipe view.
Example code triggering this: ``` python do_fetch:append() { not python code } ```
This stops showing .bbappend files not relevant to the recipe version that is used.
The tests have a complex mock infrastructure to generate the tree view. It then checks that the tree view has all the elements we expect.
Previously, the constructor was called with side effects and then the variable was never used. This could look like an unused variable to linters.
If the parsing errors test was fired before the other test, the build directory was missing, resulting in random failures: EntryNotFound (FileSystemError): Error: ENOENT: no such file or directory, open '/home/runner/work/vscode-bitbake/vscode-bitbake/integration-tests/project-folder/build/conf/bblayers.conf'
a85af39
to
99d3ca3
Compare
|
That's because you are using relative paths without ${workspaceFolder}. However it should behave the same between the scanner and the tasks. I'll file a bug to address this. Is it ok if we do that in a separate PR? @WilsonZiweiWang |
Sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me
No description provided.