Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 13349 missing hover information #70

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

WilsonZiweiWang
Copy link
Collaborator

@WilsonZiweiWang WilsonZiweiWang commented Nov 13, 2023

The hover definition should show for Yocto variables and should show the one for Yocto in case of duplicate variable names.

Copy link
Member

@idillon-sfl idillon-sfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, missed the failing test

Copy link
Member

@idillon-sfl idillon-sfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Yesterday the tests were showing an error for a simple spacing mismatch, but now it seems fine, while there has been no change and the tests do not seem to have run again 🤔

@deribaucourt
Copy link
Member

I'm confused. Yesterday the tests were showing an error for a simple spacing mismatch, but now it seems fine, while there has been no change and the tests do not seem to have run again 🤔

The test failing was the parsing integration test because of an identified race condition. I manually relaunched the tests on this PR to have an accurate result. I'm fixing the race condition right now.

@WilsonZiweiWang WilsonZiweiWang merged commit ad260b8 into staging Nov 14, 2023
@WilsonZiweiWang WilsonZiweiWang deleted the Bug-13349-Missing-hover-information branch November 14, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants