Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #84

Merged
merged 13 commits into from
Nov 20, 2023
Merged

Refactor #84

merged 13 commits into from
Nov 20, 2023

Conversation

WilsonZiweiWang
Copy link
Collaborator

@WilsonZiweiWang WilsonZiweiWang commented Nov 17, 2023 •
edited
Loading

Get rid of the contextHandler as it only serves as a middleman role.
Follow the commit history for what steps were taken.

@WilsonZiweiWang
Chore: Add directive statement keywords type
bb68796
@WilsonZiweiWang
Refactor: refactor how keyword is retrieved
15412b8
@WilsonZiweiWang
Chore: Remove unused file
7586172
@WilsonZiweiWang
Chore: use directive statement keyword type
513cc71
@WilsonZiweiWang
Chore: Not passing projectScanner when constructing definitionProvide…
23db11c 
…r as there is only one instance
@WilsonZiweiWang
Chore: Remove symbolScanner setter as it is unnecessary
8c60243
@WilsonZiweiWang
Chore: Unextract the function at it is only referenced once
ef2ef44
@WilsonZiweiWang
Chore: Export an instance of definitionProvider as only one was neede…
3efba43 
…d previously
@WilsonZiweiWang
Chore: Set symbol scanner directly on the definitionProvider instance…
57f537a 
… instead of through contextProvider
@WilsonZiweiWang
Chore: Move functions from contextHandler to here
9908599
@WilsonZiweiWang
Chore: Remove contextHandler
a6c76c1
@WilsonZiweiWang
Chore: Remove file for it is not referenced by anything
db2b3cf
@WilsonZiweiWang
Chore: Update tests and restore all mocks after each test
6534007
@WilsonZiweiWang WilsonZiweiWang self-assigned this Nov 17, 2023
@WilsonZiweiWang WilsonZiweiWang marked this pull request as ready for review November 18, 2023 14:45
deribaucourt
deribaucourt approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/src/SymbolScanner.ts Show resolved Hide resolved
@WilsonZiweiWang WilsonZiweiWang merged commit 2ade6d7 into staging Nov 20, 2023
@WilsonZiweiWang WilsonZiweiWang deleted the Task-13384-Refactor branch November 20, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deribaucourt deribaucourt deribaucourt approved these changes

@idillon-sfl idillon-sfl Awaiting requested review from idillon-sfl

Assignees

@WilsonZiweiWang WilsonZiweiWang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilsonZiweiWang @deribaucourt