Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing video to AVI does not work #2

Open
choeger opened this issue May 20, 2016 · 1 comment
Open

Writing video to AVI does not work #2

choeger opened this issue May 20, 2016 · 1 comment

Comments

@choeger
Copy link

choeger commented May 20, 2016

When trying to write multiple images, the resulting file cannot be played. This seems to be caused by tools expecting every frame in one CHUNK.

the write method should look like this:

      method write buf ofs len =
        for i = ofs to ofs + len - 1 do
          let s = Image.RGBA32.to_RGB24_string buf.(i) in
          self#output "00db";
          self#output_int (String.length s);
          self#output s;
          datalen <- datalen + String.length s + 8;
        done;
        dataframes <- dataframes + len

(close and initializer need to be adapted as well, I cannot make a patch just now)

@smimram
Copy link
Member

smimram commented May 24, 2016

Yes, the current code is not satisfactory, and should be rewritten quite a bit (in particular, we'd like to be able to write audio as well). The code we actually use is here: https://github.com/savonet/liquidsoap/blob/master/src/tools/avi.ml and this one was more of a demo. To make it short: we would be glad to accept patches, but probably won't have time to update this soon...

toots added a commit that referenced this issue May 28, 2019
Avoid returning EXIT_SUCCESS when boostrap failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants