cookie handling in httpclient adapter

[sroller]

Hi Daniel,

do you remember the problems I had recently with the handling of multiple cookies and the httpclient adapter? It works with curb though.

The problem is that the method response.header.all.flatten can't handle multiple headers with the same key. I tried to mimick the behaviour of the curb adapter.
It works for me, on Windows. Can't easily test on other platforms.
Please have and integrate if appropriate.

-st

[rubiii]

hi steffen. that looks a little too complex to pull without specs.
do you think you can add a spec for this to document the behavior?

[sroller]

Hi Daniel,

with specs you mean some RSpec stuff to run against? Sure, will do that.
It's a new challenge :-)

-st

2012/6/7 Daniel Harrington <
reply@reply.github.com

hi steffen. that looks a little too complex to pull without specs.
do you think you can add a spec for this to document the behavior?

---

Reply to this email directly or view it on GitHub:
https://github.com/rubiii/httpi/pull/52#issuecomment-6176833

[rubiii]

cool :)

[sroller]

Habe mal wieder Zeit gefunden um mich an den kleinen Patch für http_client
zu machen.
Frage: Wenn ich rake (und damit rspec) starte, kann curb nicht gefunden
werden.
wenn ich das aus irb oder aus anderen Skripten mache, funktioniert das
tadellos :-(. Ist da irgendwas anders, wenn die specs laufen? Load_path
oder sowas?

-st

2012/6/7 Daniel Harrington <
reply@reply.github.com

cool :thumbsup"

---

Reply to this email directly or view it on GitHub:
https://github.com/rubiii/httpi/pull/52#issuecomment-6177679

[rubiii]

hi steffen. the Rakefile doesn't include any Bundler setup, so you have to call tasks with bundle exec.
the spec_helper should load all dependencies (including optional ones like curb) via Bundler though.

[sroller]

I'm still not able to start rake to run the specs from httpclient :-(
I cloned the latest repository, run bundle. Installed the curb gem on Windows.
But neither RAKE nor BUNDLE EXEC RAKE works. It fails because
require 'curb' fails. curb itself works, I can use it in scripts.
Any idea what I might miss?

[rubiii]

apart from a gzip-related problem with rbx (which should be fixed as soon as rbx is updated in travis),
the latest build of the master branch is passing on linux.

curb is specified to only be used in what bundler considers a :ruby platform though.
maybe your problem is related to this?

[sroller]

That gives some hints. in http://gembundler.com/man/gemfile.5.html is stated:

There are a number of Gemfile platforms:

ruby C Ruby (MRI) or Rubinius, but NOT Windows

I am on Windows. :-) Let's see what I can do.

[rogerleite]

Now that i realized this issue is the same as this #69

[sroller]

Yo man, danke für's fixen.

[rogerleite]

Nichts zu danken. (I don't know German, Google translate helped me! 😄)

[sroller]

Not a problem. This time Goggle served you well ;-)
Merry Christmas!

-st
Sent from my BlackBerry

-----Original Message-----
From: Roger Leite notifications@github.com
Date: Fri, 21 Dec 2012 04:44:17
To: savonrb/httpihttpi@noreply.github.com
Reply-To: savonrb/httpi reply@reply.github.com
Subject: Re: [httpi] cookie handling in httpclient adapter (#52)

Nichts zu danken. (I don't know German, Google translate helped me! 😄)

---

Reply to this email directly or view it on GitHub:
#52 (comment)