CI: Avoid 3.0 becoming "3" in YAML #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stringifying 3.0, the CI's YAML engine would create the string "3" rather than "3.0". Turning this specific value into a String avoids this display difference.
|
thank you for your attention to detail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
This is a change to the CI build configuration.
Did you add tests for your changes?
None, the change can be seen in how the names of the matrix elements are displayed.
Summary of changes
When stringifying 3.0, the CI's YAML engine would create the string "3" rather than "3.0". Turning this specific value into a String avoids this display difference.
This is a very small change, but which avoids a Float-to-String loss of characters.
An example (not from this project) of what it can look like before this change, in this picture:
Read more details, if you like: actions/runner#849