Add option for ssl_cert_key_password #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you very much @thefooj. could you please add an option spec for this? |
|
you're welcome @rubiii. Thanks for all you work on savonrb. Added the options spec and also some more on testing that the ssl decrypting works. Let me know if you need anything else |
|
excellent specs 👍 thanks again! |
rubiii
added a commit
that referenced
this pull request
Jan 25, 2013
Add option for ssl_cert_key_password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables specifying an SSL cert key password to decrypt an encrypted private key .pem file. When doing SSL certificate-based authentication, we are currently able to set
:ssl_cert_key_file,:ssl_cert_file,:ssl_ca_cert_file. This pull request allows an additional:ssl_cert_key_passwordglobal setting. This is passed to httpi/net-httpcert_key_password=in configuring SSL authentication.