Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lib/savon/builder.rb #400

Closed
wants to merge 1 commit into from
Closed

Update lib/savon/builder.rb #400

wants to merge 1 commit into from

Conversation

rankin
Copy link

@rankin rankin commented Feb 22, 2013

Ability to disable namespace identifier. This is necessary for certain services like Zimbra's Soap API.

This code change allows for Savon.client(namespace_identifier: :none)

Update lib/savon/builder.rb
c5acabc 
Ability to disable namespace identifier
@rankin rankin mentioned this pull request Feb 22, 2013
Closed
@rubiii
Copy link
Contributor

rubiii commented Feb 26, 2013

i would actually prefer nil instead of a "magic symbol" here, because i think it's more intuitive.
and i would need specs for this. you should easily be able to add a spec for this here.

@r4um r4um mentioned this pull request Mar 22, 2013
Merged
@rubiii
Copy link
Contributor

rubiii commented Mar 31, 2013

merged #416.

@rubiii rubiii closed this Mar 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rankin @rubiii