Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client#build_request method to version 2 #620

Closed

Conversation

jpmoral
Copy link

@jpmoral jpmoral commented Sep 24, 2014

#build_request returns the request without actually making the call. This accepts the same parameters as #call

JP Moral added 2 commits September 10, 2014 10:53
Returns the request without making an actual call
Returns request without making an actual call
@jpmoral jpmoral changed the title Add Client#build_request method Add Client#build_request method to version 2 Sep 24, 2014
@tjarratt
Copy link
Contributor

Merged this manually from the command line because merging your branch made the history of the project look a little strange. I guess your pull request was started from Savon v2.4.0, somehow merging in that branch caused a lot of merge conflicts. It's strange that GitHub will even let me merge it here.

Anyway, it's not a big deal. This should be on master now!

Thank you so much for contributing to Savon, @jpmoral.

@tjarratt tjarratt closed this Sep 24, 2014
@jpmoral
Copy link
Author

jpmoral commented Sep 25, 2014

@tjarratt thanks for merging! I'd hoped to get this into the version2 branch. How does that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants