Logging: Use filter without automatic pretty printing #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filter functionality is using nokogiri to filter out unwanted elements. The default `.to_xml` of nokogiri automatically pretty prints the document, even if the pretty_print_xml option is set to false. This commit fixes this, by applying the filter and taking the `pretty_print_xml = false` into account. See http://stackoverflow.com/questions/8406251/nokogiri-to-xml-without-carriage-returns for details of using nokogiri without carriage returns.
|
Please excuse the failing build. The failing test case seems to be failing on master even without this commit. |
olleolleolle
approved these changes
Dec 19, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter functionality is using nokogiri to filter out unwanted
elements. The default
.to_xmlof nokogiri automatically pretty printsthe document, even if the pretty_print_xml option is set to false.
This commit fixes this, by applying the filter and taking the
pretty_print_xml = falseinto account.See http://stackoverflow.com/questions/8406251/nokogiri-to-xml-without-carriage-returns
for details of using nokogiri without carriage returns.