Add multipart request sending option #761
Conversation
|
This is great! Any update on when we could get a merge? |
|
I'm still working on it, because the Mail module was changed in meantime.
I'll send a new pull-request soon.
2017-05-31 22:59 GMT+02:00 Chris Ostrowski <notifications@github.com>:
… This is great! Any update on when we could get a merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#761 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACbWSMN-vY61Qv1OCwZDyLc-5yKRhputks5r_dSggaJpZM4IS5Lo>
.
|
dukaarpad
force-pushed
the
master
branch
2 times, most recently
from
daaad6b
to
d74d25a
Compare
|
The Mail::Patterns reference is removed (it was omitted from Mail). |
|
👍 In my humble opinion, it is an utterly important thing. Are there any reasons, why this request can't be merged? |
|
Guys any update on this? |
If attachments are raw binary format, split may throw ArgumentError: invalid byte sequence in UTF-8 exception.
the Mail module removed this lib in meantime
|
Hi, I made tests, cleaned the code and rebased with actual version. I cannot do more. |
|
Please guys, this is an important PR. |
|
Hi,
Yes, of course you may fork it. I'll keep it while it will be pulled in
main gem, because I already have around 15 rails applications in
production, which uses this gem with these features.
And also, if you have some further fixes or developments, feel free to code
it an send a pull request.
Best,
Duka
2017-10-31 0:11 GMT+01:00 Jordano Moscoso <notifications@github.com>:
… Heeeey, @dukaarpad <https://github.com/dukaarpad> can I use ur fork
meanwhile this PR is accepted?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#761 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACbWSL5XlkN7IFEf_V9B0RF8e9691S6fks5sxleUgaJpZM4IS5Lo>
.
|
README.md
Outdated
| @@ -22,7 +22,7 @@ $ gem install savon | |||
| or add it to your Gemfile like this: | |||
|
|
|||
| ``` | |||
| gem 'savon', '~> 2.11.1' | |||
| gem 'savon', '~> 2.12.0' | |||
There was a problem hiding this comment.
can you please revert this change? This version is not yet released.
|
Apologies for the lack of movement here. The reason I have not merged is because it looks like a large change, including introducing new dependency, and haven't had much time to dig into it. I looked at it briefly just now, over next few days I will try to do a more detailed pass. Thanks everyone for your patience. |
|
Please check it deeply and tell if you see problems. And even if you found something which could be solved in a better or prettier way. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
We are still using this feature and would be good if it will be merged in main branch. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please do not close this. It's alive and we are still waiting to be merged in main repo. |
|
Thanks for your contribution and for your patience. |
|
Thanks for your help.
Regards,
Duka Árpád
2018-04-29 18:34 GMT+02:00 Peter Cai <notifications@github.com>:
… Thanks for your contribution and for your patience.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#761 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACbWSIyI2gVERUsNuOEqH9EVlY2Z2BsPks5tteuqgaJpZM4IS5Lo>
.
|
|
Anyone have a complete sample for request with attachments? |
|
If am I right, it is not on 2.12.0 As @Erpizzo72 says, someone could help us on how to implement it? |
|
Hi, is this working somehow with SOAP/XOP https://www.w3.org/TR/xop10/ because this change has broke this functionality in connection with the https://github.com/savonrb/savon-multipart gem Is it possible to bringt |
According to https://www.w3.org/TR/SOAP-attachments