Fix: Remove xmlns:wsa's already added elsewhere; select Content-Type HTTP header based on SOAP version #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing this back. Are you still having trouble running tests? If so, please share the output of |
jackozi
approved these changes
Apr 24, 2019
olleolleolle
approved these changes
Jul 3, 2020
| @@ -11,6 +11,11 @@ | |||
| module Savon | |||
| class Operation | |||
|
|
|||
| SOAP_REQUEST_TYPE = { | |||
There was a problem hiding this comment.
We could call it content types in the name, I guess.
olleolleolle
changed the title
olleolleolle
changed the title
pcai
pushed a commit
that referenced
this pull request
Jul 5, 2020
…HTTP header based on SOAP version (#868) * remove unneeded xmlns:wsa, already added elsewhere * clean up Content-Type header and add MIME-Version * select header Content-Type based on SOAP version * xmlns:wsa attribute is not needed on wsa:MessageID. it's already included in the header Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
|
xmlns:wsa attribute is not needed on wsa:MessageID. In what savon version is this applied? I need this version, dont know how to remove the attribute. I am using 2.12.1 |
|
Im not sure if because of this, but now the https://github.com/savonrb/savon-multipart gem is not working anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of changes I needed for multipart support to work with a server using Axis2.
I'm having a little trouble running the test suite on my system, but I'll work on that.