Fix elementFormDefault="qualified" regression

[lukaso]

Types were not properly qualified

What kind of change is this?

Bugfix

Did you add tests for your changes?

Yes. I've now added a breaking test which ensures the message is properly encoded.

Summary of changes

This fixes a bug raised in #916. This means more recent versions of Savon do not work properly in certain specific circumstances when elements are embedded in types.

Other information

The test is based on a real-world wsdl file in which messages are being incorrectly "qualified".

[lukaso]

Given the slow pace of incorporating changes, I've created a gem that patches this issue. All you have to do is include it in your Gemfile:

gem 'savon_fixes'

You can find the gem here: https://github.com/lukaso/savon_fixes. It currently covers off these issues and PRs: #916, #899, #820, #895, #862, #905 and #549 (they are all duplicates).

I haven't yet tested it in anger, but all tests pass, so please feedback if there are any issues. Adaptations of PRs here are also welcome.

[sergioisidoro]

@lukaso does those fixes also patch this one?
#830

[lukaso]

@lukaso does those fixes also patch this one?
#830

Yes, I believe it does. Thanks for tracking that down.

[pcai]

@lukaso thanks! I apologize for the long turnaround. It looks like you did this by the book and added a failing test. I read through this change and can confirm it makes it pass now. Just acknowledging this while I dig into the details to understand the intended behavior and the bug.

[pcai]

OK I reread #916 and it was mentioned there, but the most succinct way to summarize the actual/expected behavior is the diff of the test output before and after the fix in this PR:

Given a WSDL with elementFormDefault="qualified", the attribute will now be correctly qualified with the namespace.

This LGTM, I'll check if I can confirm the jruby failure is bogus and merge this in.

[pcai]

https://travis-ci.org/github/savonrb/savon/builds/705227195 passes so 👍

[lukaso]

Thank you!