Allow the write timeout option to be set #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HashNotAdam This passes on all the MRI Ruby versions, which is grand. JRuby issues are dealt with separately. We have currently set that build target to Thanks for the improvement. Next steps: Can you rebase and add a CHANGELOG.md line? |
Write timeout is supported by HTTPI but not by Savon. While not having the setting is limiting, it can also cause issues in adapters. For example, when setting timeouts per operation in HTTP, any timeouts not supplied will be set to 0.25 seconds which can lead to unexpected surprises for users
HashNotAdam
force-pushed
the
feature/add_write_timeout_option
branch
from
ffee149
to
8a59b39
Compare
|
@olleolleolle all good |
olleolleolle
approved these changes
Jul 27, 2020
|
👋 Would it be easy to release a new version with this new feature? 🙏 |
Ditto here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Feature
Summary of changes
Fixes #834 Supports write_timeout option.
Write timeout is supported by HTTPI but not by Savon.
Other information
While not having the setting is limiting, it can also cause issues in
adapters. For example, when setting timeouts per operation in HTTP, any
timeouts not supplied will be set to 0.25 seconds which can lead to
unexpected surprises for users